Skip to content

Commit 71bdeb5

Browse files
ci: stop Dependabot grouping crypto crates as "rust-non-crypto" (#45)
The rust-non-crypto group matched "*" and excluded ml-kem, ml-dsa, hkdf, sha2, sha3, generic-array, rand_core and zeroize -- but not the dalek crates. So x25519-dalek and ed25519-dalek, which back the hybrid X25519/Ed25519 KEM and signature paths, fell through into a group named "non-crypto". That is how PR #37 came to propose x25519-dalek 2.0 -> 3.0 and ed25519-dalek 2.1 -> 3.0 as a single routine update. It broke the build outright: cargo could not even resolve, because ed25519-dalek 3.0 removed the `std` feature that pqf-reader requests. Because pqf-writer path-depends on pqf-reader, all 11 Rust-dependent checks failed while every .NET check passed. Adds *dalek*, aes-gcm, aead, signature and digest to the exclusions, so anything implementing or underpinning a cryptographic primitive arrives as its own reviewable PR. A major bump to any of them is never routine. After this, the group covers only base64, hex, serde, serde_json and typenum -- genuinely non-cryptographic, which is what the name always claimed. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 parent 2cf08ff commit 71bdeb5

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

.github/dependabot.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,12 @@ updates:
4545
patterns:
4646
- "*"
4747
exclude-patterns:
48+
# Anything that implements or underpins a cryptographic primitive is
49+
# excluded so it arrives as its own reviewable PR. A major bump to one
50+
# of these is never a routine update: x25519-dalek 3.0 and
51+
# ed25519-dalek 3.0 arrived grouped as "rust-non-crypto" and broke the
52+
# build outright, because ed25519-dalek 3.0 removed the `std` feature
53+
# that pqf-reader requests.
4854
- "ml-kem"
4955
- "ml-dsa"
5056
- "hkdf"
@@ -53,6 +59,11 @@ updates:
5359
- "generic-array"
5460
- "rand_core"
5561
- "zeroize"
62+
- "*dalek*"
63+
- "aes-gcm"
64+
- "aead"
65+
- "signature"
66+
- "digest"
5667

5768
# GitHub Actions. Safe to group everything.
5869
- package-ecosystem: "github-actions"

0 commit comments

Comments
 (0)