Allow extension handlers to fall through to default logic

Author: iansan5653

dev/lib/index.js

@@ -1309,9 +1309,15 @@ function extension(combined, extension) {
 
         case 'enter':
         case 'exit': {
+          const left = combined[key]
           const right = extension[key]
-          if (right) {
-            Object.assign(combined[key], right)
+          for (const tokenType in right) {
+            if (right[tokenType]) {
+              left[tokenType] = combineHandles(
+                left[tokenType],
+                right[tokenType]
+              )
+            }
           }
 
           break
@@ -1322,6 +1328,22 @@ function extension(combined, extension) {
   }
 }
 
+/**
+ * Creates a new handle that calls `right` first, then falls through to `left`
+ * only if `right` explicitly returns `false`.
+ * @param {Handle?} left
+ * @param {Handle} right
+ * @returns {Handle}
+ */
+function combineHandles(left, right) {
+  if (!left) return right
+
+  return function (...params) {
+    const rightResult = right.apply(this, params)
+    return rightResult === false ? left.apply(this, params) : rightResult
+  }
+}
+
 /** @type {OnEnterError} */
 function defaultOnError(left, right) {
   if (left) {

dev/lib/types.d.ts

@@ -226,9 +226,10 @@ export type Handles = Record<string, Handle>
  * @param token
  *   Current token.
  * @returns
- *   Nothing.
+ *   Nothing, if the token was fully handled by this extension and should be ignored by previous extensions / default logic.
+ *   Or `false`, if the token has not been handled by this extension and handling should fall back to preceding logic.
  */
-export type Handle = (this: CompileContext, token: Token) => undefined | void
+export type Handle = (this: CompileContext, token: Token) => undefined | void | false
 
 /**
  * Handle the case where the `right` token is open, but it is closed (by the

readme.md

@@ -248,7 +248,9 @@ Handle a token (TypeScript type).
 
 ###### Returns
 
-Nothing (`undefined`).
+Nothing, if the token was fully handled and should be ignored by previous
+extensions / default logic. Or `false`, if the token has not been handled here
+and the parser should fall back to preceding logic.
 
 ### `OnEnterError`
 

test/index.js

@@ -146,6 +146,51 @@ test('fromMarkdown', async function (t) {
     )
   })
 
+  await t.test(
+    'should allow extension handlers to fall through',
+    async function () {
+      assert.deepEqual(
+        fromMarkdown('a\nb', {
+          mdastExtensions: [
+            {
+              enter: {
+                paragraph() {
+                  return false
+                }
+              }
+            }
+          ]
+        }),
+        {
+          type: 'root',
+          children: [
+            {
+              type: 'paragraph',
+              children: [
+                {
+                  type: 'text',
+                  value: 'a\nb',
+                  position: {
+                    start: {line: 1, column: 1, offset: 0},
+                    end: {line: 2, column: 2, offset: 3}
+                  }
+                }
+              ],
+              position: {
+                start: {line: 1, column: 1, offset: 0},
+                end: {line: 2, column: 2, offset: 3}
+              }
+            }
+          ],
+          position: {
+            start: {line: 1, column: 1, offset: 0},
+            end: {line: 2, column: 2, offset: 3}
+          }
+        }
+      )
+    }
+  )
+
   await t.test('should support multiple extensions', async function () {
     assert.deepEqual(
       fromMarkdown('a\nb', {