minor #1162 Move some constant to a better place (javiereguiluz)

This PR was squashed before being merged into the master branch.

Discussion
----------

Move some constant to a better place

This continues #1160 to refactor some code.

Commits
-------

0de89e1 Move some constant to a better place

Author: javiereguiluz

src/Entity/Post.php

@@ -35,14 +35,6 @@
  */
 class Post
 {
-    /**
-     * Use constants to define configuration options that rarely change instead
-     * of specifying them under parameters section in config/services.yaml file.
-     *
-     * See https://symfony.com/doc/current/best_practices.html#use-constants-to-define-options-that-rarely-change
-     */
-    public const NUM_ITEMS = 10;
-
     /**
      * @var int
      *

src/Pagination/Paginator.php

@@ -11,7 +11,6 @@
 
 namespace App\Pagination;
 
-use App\Entity\Post;
 use Doctrine\ORM\QueryBuilder as DoctrineQueryBuilder;
 use Doctrine\ORM\Tools\Pagination\CountWalker;
 use Doctrine\ORM\Tools\Pagination\Paginator as DoctrinePaginator;
@@ -21,13 +20,21 @@
  */
 class Paginator
 {
+    /**
+     * Use constants to define configuration options that rarely change instead
+     * of specifying them under parameters section in config/services.yaml file.
+     *
+     * See https://symfony.com/doc/current/best_practices.html#use-constants-to-define-options-that-rarely-change
+     */
+    public const PAGE_SIZE = 10;
+
     private $queryBuilder;
     private $currentPage;
     private $pageSize;
     private $results;
     private $numResults;
 
-    public function __construct(DoctrineQueryBuilder $queryBuilder, int $pageSize = Post::NUM_ITEMS)
+    public function __construct(DoctrineQueryBuilder $queryBuilder, int $pageSize = self::PAGE_SIZE)
     {
         $this->queryBuilder = $queryBuilder;
         $this->pageSize = $pageSize;

src/Repository/PostRepository.php

@@ -57,7 +57,7 @@ public function findLatest(int $page = 1, Tag $tag = null): Paginator
     /**
      * @return Post[]
      */
-    public function findBySearchQuery(string $query, int $limit = Post::NUM_ITEMS): array
+    public function findBySearchQuery(string $query, int $limit = Paginator::PAGE_SIZE): array
     {
         $searchTerms = $this->extractSearchTerms($query);
 

tests/Controller/BlogControllerTest.php

@@ -12,6 +12,7 @@
 namespace App\Tests\Controller;
 
 use App\Entity\Post;
+use App\Pagination\Paginator;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 
 /**
@@ -34,7 +35,7 @@ public function testIndex(): void
         $this->assertResponseIsSuccessful();
 
         $this->assertCount(
-            Post::NUM_ITEMS,
+            Paginator::PAGE_SIZE,
             $crawler->filter('article.post'),
             'The homepage displays the right number of posts.'
         );
@@ -48,7 +49,7 @@ public function testRss(): void
         $this->assertResponseHeaderSame('Content-Type', 'text/xml; charset=UTF-8');
 
         $this->assertCount(
-            Post::NUM_ITEMS,
+            Paginator::PAGE_SIZE,
             $crawler->filter('item'),
             'The xml file displays the right number of posts.'
         );