reintroduce cmf_routing.dynamic.persistence.phpcr.route_basepath for BC

[lsmith77]

One of the biggest issues when updating to 1.1 is the fact that cmf_routing.dynamic.persistence.phpcr.route_basepath is no longer available.

cmf_routing.dynamic.persistence.phpcr.admin_basepath is only available when sonata admin is active and the new parameter cmf_routing.dynamic.persistence.phpcr.route_basepaths is not as convenient for the common case of just a single base path.

maybe we should therefore consider to reintroduce cmf_routing.dynamic.persistence.phpcr.route_basepath with the first path in the cmf_routing.dynamic.persistence.phpcr.route_basepaths array.

[ElectricMaxxx]

👍
I had to feel that deprecation and it hurts. We could reintroduce the value while setting the admin_basepath (https://github.com/symfony-cmf/RoutingBundle/blob/master/DependencyInjection/CmfRoutingExtension.php#L282)

I would suggest to keep that double handling until 1.3 There is no chance to mark configs as deprecated as we did for the setParent() method?

[dbu]

that is the intention of https://github.com/symfony-cmf/RoutingBundle/blob/master/DependencyInjection/Configuration.php#L80 - but with the core bundle prepending basepaths this probably never works as intended.

[wouterj]

I think it just works as @dbu said. Otherwise, we should introduce a normalizer.

[lsmith77]

Not sure if we understand each other properly. What I mean is to reintroduce the parameter. Right now that parameter is no longer defined.

[lsmith77]

right now we do, if sonata is active:

        $basePath = empty($config['admin_basepath']) ? reset($config['route_basepaths']) : $config['admin_basepath'];
        $container->setParameter($this->getAlias() . '.dynamic.persistence.phpcr.admin_basepath', $basePath);

I would want the same to always be done for the old parameter name.

[lsmith77]

or in other words:

diff --git a/DependencyInjection/CmfRoutingExtension.php b/DependencyInjection/CmfRoutingExtension.php
index faf6b91..4849536 100644
--- a/DependencyInjection/CmfRoutingExtension.php
+++ b/DependencyInjection/CmfRoutingExtension.php
@@ -239,6 +239,13 @@ class CmfRoutingExtension extends Extension
             $this->getAlias() . '.dynamic.persistence.phpcr.route_basepaths',
             $config['route_basepaths']
         );
+
+        $basePath = reset($config['route_basepaths']);
+        $container->setParameter(
+            $this->getAlias() . '.dynamic.persistence.phpcr.route_basepath',
+            $basePath
+        );
+
         $container->setParameter(
             $this->getAlias() . '.dynamic.persistence.phpcr.content_basepath',
             $config['content_basepath']

[dbu]

ah now i get it. you want the old parameter available in the environment, not as a configuration option. agreed, lets do that (but document as deprecated, right?). in general, it is wrong to assume that there can only be one such path.

[lsmith77]

see #235