chore: keystore transaction signing #1532
Conversation
| chain === Chain.BitcoinCash | ||
| ? (toolbox as UTXOToolboxes["BCH"]).buildTx | ||
| : (toolbox as UTXOToolboxes["BTC"]).createTransaction; | ||
| const createTxMethod = (toolbox as UTXOToolboxes["BTC"]).createTransaction; |
There was a problem hiding this comment.
I need to fix this up real quick 👁️ 👁️
|
|
||
| const isEVMTransaction = (tx: unknown) => EVMTransactionSchema.safeParse(tx).success; | ||
| const isTronTransaction = (tx: unknown) => TronTransactionSchema.safeParse(tx).success; | ||
| const isCosmosTransaction = (tx: unknown) => CosmosTransactionSchema.safeParse(tx).success; |
There was a problem hiding this comment.
should we have isUtxoTransaction , Near and Solana helpers too?
There was a problem hiding this comment.
No - those falls into generic type afaik
There was a problem hiding this comment.
this is just testing the tx that API sends, against the schemas I copied from the API repo to have type safety
There was a problem hiding this comment.
So no need for the API to have access to that, that would be kinda ... in a circle.
API defines types
SDK manually has to copy them
API uses manually copied types to check their own types
There was a problem hiding this comment.
It supposed to be taken from API typings like openapi or sth - but we never got those in place
Its the deployment I am building for Ochhii |
No description provided.