fix: Produce an error when $props.id() is used after an await #17273
+33
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sveltejs/kit#14994
When
$props.id()is used after an await, the compiler fails and throw an unexpected error :In fact there is a conflict between the behavior of
$.run()and the early initialization of$props.id().I looked at the generated code, and I think several compiler modifications would be needed to handle that case... :/
But there is absolutely no advantage for declaring
$props.id()after anawait, so I think the best solution would be to display a more explicit message.This PR patch the compiler to produce these error on
$props.id():Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint