chore: apply pr comment

Author: avallete

src/lib/PostgresMeta.ts

@@ -22,7 +22,7 @@ import { init } from './db.js'
 import { PostgresMetaResult, PoolConfig } from './types.js'
 
 export default class PostgresMeta {
-  query: (sql: string, customQuery?: boolean) => Promise<PostgresMetaResult<any>>
+  query: (sql: string, trackQueryInSentry?: boolean) => Promise<PostgresMetaResult<any>>
   end: () => Promise<void>
   columnPrivileges: PostgresMetaColumnPrivileges
   columns: PostgresMetaColumns

src/lib/db.ts

@@ -62,7 +62,7 @@ const poolerQueryHandleError = (pgpool: pg.Pool, sql: string): Promise<pg.QueryR
 }
 
 export const init: (config: PoolConfig) => {
-  query: (sql: string, customQuery?: boolean) => Promise<PostgresMetaResult<any>>
+  query: (sql: string, trackQueryInSentry?: boolean) => Promise<PostgresMetaResult<any>>
   end: () => Promise<void>
 } = (config) => {
   return Sentry.startSpan({ op: 'db', name: 'db.init' }, () => {
@@ -103,10 +103,14 @@ export const init: (config: PoolConfig) => {
     let pool: pg.Pool | null = new pg.Pool(config)
 
     return {
-      async query(sql, customQuery = false) {
+      async query(sql, trackQueryInSentry = true) {
         return Sentry.startSpan(
           // For metrics purposes, log the query that will be run if it's not an user provided query (with possibly sentitives infos)
-          { op: 'db', name: 'init.query', attributes: { sql: customQuery ? 'custom' : sql } },
+          {
+            op: 'db',
+            name: 'init.query',
+            attributes: { sql: trackQueryInSentry ? sql : 'custom' },
+          },
           async () => {
             try {
               if (!pool) {

src/server/routes/query.ts

@@ -21,7 +21,7 @@ export default async (fastify: FastifyInstance) => {
     const connectionString = request.headers.pg
 
     const pgMeta = new PostgresMeta({ ...DEFAULT_POOL_CONFIG, connectionString })
-    const { data, error } = await pgMeta.query(request.body.query, true)
+    const { data, error } = await pgMeta.query(request.body.query, false)
     await pgMeta.end()
     if (error) {
       request.log.error({ error, request: extractRequestForLogging(request) })