Skip to content

Commit 5b8237c

Browse files
authored
Merge pull request #62 from supabase-community/fix-ecs-service-connect
fix: Disable ECS ServiceConnect
2 parents 15f28a3 + 206da1b commit 5b8237c

File tree

5 files changed

+8
-224
lines changed

5 files changed

+8
-224
lines changed

.github/workflows/cfn-publish-stable.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
- 'v*'
66
env:
77
BSS_FILE_ASSET_BUCKET_NAME: 'supabase-on-aws-${AWS::Region}'
8-
BSS_FILE_ASSET_REGION_SET: us-east-1,us-west-2,eu-west-1,ap-northeast-1,ap-northeast-2,ap-northeast-3,ap-southeast-1,ap-southeast-2
8+
BSS_FILE_ASSET_REGION_SET: us-east-1,us-west-2,eu-west-1,ap-northeast-1,ap-northeast-2,ap-northeast-3,ap-southeast-1,ap-southeast-2,ap-south-1
99

1010
jobs:
1111
stable:

.github/workflows/cfn-publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77

88
env:
99
BSS_FILE_ASSET_BUCKET_NAME: 'supabase-on-aws-${AWS::Region}'
10-
BSS_FILE_ASSET_REGION_SET: us-east-1,us-west-2,eu-west-1,ap-northeast-1,ap-northeast-2,ap-northeast-3,ap-southeast-1,ap-southeast-2
10+
BSS_FILE_ASSET_REGION_SET: us-east-1,us-west-2,eu-west-1,ap-northeast-1,ap-northeast-2,ap-northeast-3,ap-southeast-1,ap-southeast-2,ap-south-1
1111
BSS_FILE_ASSET_PREFIX: latest/
1212

1313
jobs:

src/ecs-patterns.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export class BaseFargateService extends Construct {
6060
const { cluster, taskImageOptions } = props;
6161
const containerPort = taskImageOptions.containerPort;
6262
const cpuArchitecture = (props.cpuArchitecture == 'X86_64') ? ecs.CpuArchitecture.X86_64 : ecs.CpuArchitecture.ARM64;
63-
const enableServiceConnect = (typeof props.enableServiceConnect == 'undefined') ? true : props.enableServiceConnect;
63+
const enableServiceConnect = (typeof props.enableServiceConnect == 'undefined') ? false : props.enableServiceConnect;
6464
const enableCloudMap = (typeof props.enableCloudMap == 'undefined') ? true : props.enableCloudMap;
6565

6666
const taskDefinition = new ecs.FargateTaskDefinition(this, 'TaskDef', {

src/supabase-stack.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ export class FargateStack extends cdk.Stack {
2626

2727
this.taskSizeMapping = new cdk.CfnMapping(this, 'TaskSize', {
2828
mapping: {
29-
'none': { cpu: 256, memory: 1024 },
30-
'micro': { cpu: 256, memory: 1024 },
29+
'none': { cpu: 256, memory: 512 }, // Disable ECS Service
30+
'micro': { cpu: 256, memory: 512 },
3131
'small': { cpu: 512, memory: 1024 },
3232
'medium': { cpu: 1024, memory: 2048 },
3333
'large': { cpu: 2048, memory: 4096 },

test/__snapshots__/main.test.ts.snap

Lines changed: 3 additions & 219 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)