Skip to content

Conversation

@leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Oct 23, 2025

What

Remove friendbot service.

Why

It has moved to https://github.com/stellar/friendbot.

Merging

This should be merged after a successful deployment has taken place on the new repo.

For stellar/friendbot#4

@leighmcculloch leighmcculloch marked this pull request as ready for review October 29, 2025 22:15
@leighmcculloch leighmcculloch requested review from a team and Copilot October 29, 2025 22:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR completely removes the friendbot service from the repository. The friendbot service was a REST API endpoint used to create and fund test accounts on the Stellar Test Network.

  • Removes all friendbot service code, tests, and configuration files
  • Removes friendbot Docker build configuration
  • Updates dependency files to remove github.com/go-chi/chi/v5 and github.com/riandyrn/otelchi packages
  • Removes friendbot build target from the root Makefile

Reviewed Changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
services/friendbot/main.go Deleted main entry point and server configuration
services/friendbot/router_test.go Deleted HTTP routing and IP logging tests
services/friendbot/init_friendbot.go Deleted minion account initialization logic
services/friendbot/init_friendbot_test.go Deleted minion creation tests
services/friendbot/internal/friendbot.go Deleted core Bot payment delegation logic
services/friendbot/internal/friendbot_handler.go Deleted HTTP request handler
services/friendbot/internal/friendbot_test.go Deleted Bot payment tests
services/friendbot/internal/minion.go Deleted Minion transaction creation and submission
services/friendbot/internal/minion_test.go Deleted Minion concurrency tests
services/friendbot/internal/account.go Deleted Account interface implementation
services/friendbot/loadtest/loadtest.go Deleted load testing utility
services/friendbot/friendbot.cfg Deleted configuration file
services/friendbot/docker/Dockerfile Deleted Docker build configuration
services/friendbot/README.md Deleted service documentation
services/friendbot/Makefile Deleted service-specific build targets
services/friendbot/CHANGELOG.md Deleted service changelog
go.mod Removed chi/v5 and otelchi dependencies
go.sum Removed dependency checksums
Makefile Removed friendbot build target from root Makefile

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leighmcculloch leighmcculloch merged commit f7134eb into master Oct 29, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants