Skip to content

Commit 15ee25d

Browse files
bryangingechenstaroperator
authored andcommitted
fix: include .lake in artifact upload (leanprover-community#28092)
Follow-up to leanprover-community#28062. It turns out `.olean` files are stored in `.lake` which are excluded by default by the `actions/upload-artifact` action. We use the `include-hidden-files` option, taking care to exclude the `.git` folder which may include secrets like `GITHUB_TOKEN`, etc.
1 parent b0eacc0 commit 15ee25d

4 files changed

Lines changed: 20 additions & 4 deletions

File tree

.github/build.in.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,11 @@ jobs:
267267
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
268268
with:
269269
name: mathlib4_artifact
270-
path: pr-branch/
270+
include-hidden-files: true
271+
# we exclude .git since there may be secrets in there
272+
path: |
273+
pr-branch/
274+
!pr-branch/.git/
271275
272276
# The cache secrets are available here, so we must not run any untrusted code.
273277
- name: upload cache

.github/workflows/bors.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,11 @@ jobs:
277277
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
278278
with:
279279
name: mathlib4_artifact
280-
path: pr-branch/
280+
include-hidden-files: true
281+
# we exclude .git since there may be secrets in there
282+
path: |
283+
pr-branch/
284+
!pr-branch/.git/
281285
282286
# The cache secrets are available here, so we must not run any untrusted code.
283287
- name: upload cache

.github/workflows/build.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,11 @@ jobs:
284284
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
285285
with:
286286
name: mathlib4_artifact
287-
path: pr-branch/
287+
include-hidden-files: true
288+
# we exclude .git since there may be secrets in there
289+
path: |
290+
pr-branch/
291+
!pr-branch/.git/
288292
289293
# The cache secrets are available here, so we must not run any untrusted code.
290294
- name: upload cache

.github/workflows/build_fork.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,11 @@ jobs:
281281
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
282282
with:
283283
name: mathlib4_artifact
284-
path: pr-branch/
284+
include-hidden-files: true
285+
# we exclude .git since there may be secrets in there
286+
path: |
287+
pr-branch/
288+
!pr-branch/.git/
285289
286290
# The cache secrets are available here, so we must not run any untrusted code.
287291
- name: upload cache

0 commit comments

Comments
 (0)