Move stan::rng_t decl to Math library for consistency

Author: andrjohns

stan/math/prim/meta/rng_t.hpp

@@ -0,0 +1,12 @@
+#ifndef STAN_MATH_PRIM_META_RNG_T_HPP
+#define STAN_MATH_PRIM_META_RNG_T_HPP
+
+#include <boost/random/mixmax.hpp>
+
+namespace stan {
+
+using rng_t = boost::random::mixmax;
+
+}  // namespace stan
+
+#endif

test/unit/math/fwd/prob/lkj_corr_test.cpp

@@ -5,7 +5,7 @@
 
 TEST(ProbDistributionsLkjCorr, fvar_double) {
   using stan::math::fvar;
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   int K = 4;
   Eigen::Matrix<fvar<double>, Eigen::Dynamic, Eigen::Dynamic> Sigma(K, K);
   Sigma.setZero();
@@ -24,7 +24,7 @@ TEST(ProbDistributionsLkjCorr, fvar_double) {
 
 TEST(ProbDistributionsLkjCorrCholesky, fvar_double) {
   using stan::math::fvar;
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   int K = 4;
   Eigen::Matrix<fvar<double>, Eigen::Dynamic, Eigen::Dynamic> Sigma(K, K);
   Sigma.setZero();
@@ -43,7 +43,7 @@ TEST(ProbDistributionsLkjCorrCholesky, fvar_double) {
 
 TEST(ProbDistributionsLkjCorr, fvar_fvar_double) {
   using stan::math::fvar;
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   int K = 4;
   Eigen::Matrix<fvar<fvar<double> >, Eigen::Dynamic, Eigen::Dynamic> Sigma(K,
                                                                            K);
@@ -63,7 +63,7 @@ TEST(ProbDistributionsLkjCorr, fvar_fvar_double) {
 
 TEST(ProbDistributionsLkjCorrCholesky, fvar_fvar_double) {
   using stan::math::fvar;
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   int K = 4;
   Eigen::Matrix<fvar<fvar<double> >, Eigen::Dynamic, Eigen::Dynamic> Sigma(K,
                                                                            K);

test/unit/math/mix/prob/lkj_corr_test.cpp

@@ -9,7 +9,7 @@
 TEST(ProbDistributionsLkjCorr, fvar_var) {
   using stan::math::fvar;
   using stan::math::var;
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   int K = 4;
   Eigen::Matrix<fvar<var>, Eigen::Dynamic, Eigen::Dynamic> Sigma(K, K);
   Sigma.setZero();
@@ -31,7 +31,7 @@ TEST(ProbDistributionsLkjCorr, fvar_var) {
 TEST(ProbDistributionsLkjCorrCholesky, fvar_var) {
   using stan::math::fvar;
   using stan::math::var;
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   int K = 4;
   Eigen::Matrix<fvar<var>, Eigen::Dynamic, Eigen::Dynamic> Sigma(K, K);
   Sigma.setZero();
@@ -54,7 +54,7 @@ TEST(ProbDistributionsLkjCorrCholesky, fvar_var) {
 TEST(ProbDistributionsLkjCorr, fvar_fvar_var) {
   using stan::math::fvar;
   using stan::math::var;
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   int K = 4;
   Eigen::Matrix<fvar<fvar<var> >, Eigen::Dynamic, Eigen::Dynamic> Sigma(K, K);
   Sigma.setZero();
@@ -78,7 +78,7 @@ TEST(ProbDistributionsLkjCorr, fvar_fvar_var) {
 TEST(ProbDistributionsLkjCorrCholesky, fvar_fvar_var) {
   using stan::math::fvar;
   using stan::math::var;
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   int K = 4;
   Eigen::Matrix<fvar<fvar<var> >, Eigen::Dynamic, Eigen::Dynamic> Sigma(K, K);
   Sigma.setZero();

test/unit/math/opencl/multiply_transpose_test.cpp

@@ -7,7 +7,7 @@
 #include <boost/random/mersenne_twister.hpp>
 #include <gtest/gtest.h>
 #include <algorithm>
-boost::random::mixmax rng;
+stan::rng_t rng;
 
 TEST(MathMatrixOpenCL, multiply_transpose_exception_fail_zero) {
   stan::math::row_vector_d rv(0);

test/unit/math/opencl/prim/mdivide_left_tri_low_test.cpp

@@ -29,7 +29,7 @@ TEST(MathMatrixCL, mdivide_left_tri_low_cl_exception) {
 }
 
 void mdivide_left_tri_low_Ab_test(int size) {
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   auto m1 = stan::math::matrix_d(size, size);
   for (int i = 0; i < size; i++) {
     for (int j = 0; j < i; j++) {
@@ -57,7 +57,7 @@ void mdivide_left_tri_low_Ab_test(int size) {
 }
 
 void mdivide_left_tri_low_A_test(int size) {
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   auto m1 = stan::math::matrix_d(size, size);
   for (int i = 0; i < size; i++) {
     for (int j = 0; j < i; j++) {

test/unit/math/opencl/prim/mdivide_right_tri_low_test.cpp

@@ -29,7 +29,7 @@ TEST(MathMatrixCL, mdivide_right_tri_low_cl_exception) {
 }
 
 void mdivide_right_tri_low_Ab_test(int size) {
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   auto m1 = stan::math::matrix_d(size, size);
   for (int i = 0; i < size; i++) {
     for (int j = 0; j < i; j++) {

test/unit/math/opencl/tri_inverse_test.cpp

@@ -25,7 +25,7 @@ TEST(MathMatrixCL, inverse_cl_exception) {
 }
 
 void lower_inverse_test(int size) {
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   auto m1 = stan::math::matrix_d(size, size);
   for (int i = 0; i < size; i++) {
     for (int j = 0; j < i; j++) {
@@ -56,7 +56,7 @@ void lower_inverse_test(int size) {
 }
 
 void upper_inverse_test(int size) {
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   auto m1 = stan::math::matrix_d(size, size);
   for (int i = 0; i < size; i++) {
     for (int j = 0; j < i; j++) {

test/unit/math/prim/fun/chol2inv_test.cpp

@@ -25,7 +25,7 @@ TEST(MathMatrixPrimMat, chol2inv) {
   using stan::math::matrix_d;
   using stan::math::wishart_rng;
 
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   matrix_d I(3, 3);
   I.setZero();
   I.diagonal().setOnes();

test/unit/math/prim/prob/bernoulli_logit_glm_rng_test.cpp

@@ -9,7 +9,7 @@
 TEST(ProbDistributionsBernoulliLogitGlm, vectorized) {
   using stan::math::bernoulli_logit_glm_rng;
   //  Test scalar/vector combinations.
-  boost::random::mixmax rng;
+  stan::rng_t rng;
 
   Eigen::MatrixXd x(2, 3);
   x << 3.5, -1.5, 0.0, 2.0, 1.0, 3.0;
@@ -70,7 +70,7 @@ TEST(ProbDistributionsBernoulliLogitGlm, vectorized) {
 TEST(ProbDistributionsBernoulliLogitGlm, errorCheck) {
   using stan::math::bernoulli_logit_glm_rng;
   // Check errors for nonfinite and wrong sizes.
-  boost::random::mixmax rng;
+  stan::rng_t rng;
 
   int N = 3;
   int M = 2;
@@ -107,7 +107,7 @@ TEST(ProbDistributionsBernoulliLogitGlm, errorCheck) {
 TEST(ProbDistributionsBernoulliLogitGlm, marginalChiSquareGoodnessFitTest) {
   using stan::math::bernoulli_logit_glm_rng;
   // Check distribution of result.
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   Eigen::MatrixXd x(2, 2);
   x << 3.5, -1.5, 2.0, -1.2;
   std::vector<double> alpha{2.0, 1.0};

test/unit/math/prim/prob/bernoulli_logit_test.cpp

@@ -35,7 +35,7 @@ TEST(ProbDistributionsBernoulliLogit, distributionCheck) {
 }
 
 TEST(ProbDistributionsBernoulliLogit, error_check) {
-  boost::random::mixmax rng;
+  stan::rng_t rng;
 
   EXPECT_NO_THROW(stan::math::bernoulli_logit_rng(-3.5, rng));
   EXPECT_THROW(
@@ -44,7 +44,7 @@ TEST(ProbDistributionsBernoulliLogit, error_check) {
 }
 
 TEST(ProbDistributionsBernoulliLogit, logitChiSquareGoodnessFitTest) {
-  boost::random::mixmax rng;
+  stan::rng_t rng;
   // number of samples
   int N = 10000;