Skip to content

Fix logic bug in WaitForPodsReady that incorrectly reports pods as ready #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slyt3 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix logic bug in WaitForPodsReady that incorrectly reports pods as ready #2898

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff20ec1
Fix logic bug in WaitForPodsReady that incorrectly reports pods as ready
slyt3 Dec 4, 2025
e0872d9
Merge branch 'main' into fix/waitforpodsready-logic-bug
slyt3 Dec 4, 2025
8127572
Merge branch 'main' into fix/waitforpodsready-logic-bug
dmjb Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions test/e2e/thv-operator/virtualmcp/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,26 @@ func WaitForPodsReady(ctx context.Context, c client.Client, namespace string, la
return fmt.Errorf("pod %s is in phase %s", pod.Name, pod.Status.Phase)
}

containerReady := false
podReady := false

for _, condition := range pod.Status.Conditions {
if condition.Type == corev1.ContainersReady && condition.Status != corev1.ConditionTrue {
return fmt.Errorf("pod %s containers not ready", pod.Name)
if condition.Type == corev1.ContainersReady {
containerReady = condition.Status == corev1.ConditionTrue
}

if condition.Type == corev1.PodReady {
podReady = condition.Status == corev1.ConditionTrue
}
}

if !containerReady {
return fmt.Errorf("pod %s containers not ready", pod.Name)
}

if !podReady {
return fmt.Errorf("pod %s not ready", pod.Name)
}
}
return nil
}, timeout, 5*time.Second).Should(gomega.Succeed())
Expand Down
Loading