changes from review

Author: taskbot

cmd/thv-operator/controllers/virtualmcpserver_vmcpconfig.go

@@ -31,8 +31,9 @@ func (r *VirtualMCPServerReconciler) ensureVmcpConfigConfigMap(
 	// Create OIDC resolver to handle all OIDC types (kubernetes, configMap, inline)
 	oidcResolver := oidc.NewResolver(r.Client)
 
-	// Convert CRD to vmcp config using converter with OIDC resolver
-	converter, err := vmcpconfig.NewConverter(oidcResolver)
+	// Convert CRD to vmcp config using converter with OIDC resolver and Kubernetes client
+	// The client is needed to fetch referenced VirtualMCPCompositeToolDefinition resources
+	converter, err := vmcpconfig.NewConverter(oidcResolver, r.Client)
 	if err != nil {
 		return fmt.Errorf("failed to create vmcp converter: %w", err)
 	}

cmd/thv-operator/controllers/virtualmcpserver_vmcpconfig_test.go

@@ -47,7 +47,10 @@ func newNoOpMockResolver(t *testing.T) *oidcmocks.MockResolver {
 // newTestConverter creates a Converter with the given resolver, failing the test if creation fails.
 func newTestConverter(t *testing.T, resolver *oidcmocks.MockResolver) *vmcpconfig.Converter {
 	t.Helper()
-	converter, err := vmcpconfig.NewConverter(resolver)
+	scheme := runtime.NewScheme()
+	_ = mcpv1alpha1.AddToScheme(scheme)
+	fakeClient := fake.NewClientBuilder().WithScheme(scheme).Build()
+	converter, err := vmcpconfig.NewConverter(resolver, fakeClient)
 	require.NoError(t, err)
 	return converter
 }

cmd/thv-operator/main.go

@@ -199,6 +199,11 @@ func setupControllersAndWebhooks(mgr ctrl.Manager) error {
 	if err := (&mcpv1alpha1.VirtualMCPCompositeToolDefinition{}).SetupWebhookWithManager(mgr); err != nil {
 		return fmt.Errorf("unable to create webhook VirtualMCPCompositeToolDefinition: %w", err)
 	}
+
+	// Set up MCPExternalAuthConfig webhook
+	if err := (&mcpv1alpha1.MCPExternalAuthConfig{}).SetupWebhookWithManager(mgr); err != nil {
+		return fmt.Errorf("unable to create webhook MCPExternalAuthConfig: %w", err)
+	}
 	//+kubebuilder:scaffold:builder
 
 	return nil