Skip to content

Commit 7ab7453

Browse files
committed
FIX rs.Next(). If .Next returns False, following .Get will return <nil>
1 parent 56c5347 commit 7ab7453

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

generator/templates/resultset.tgo

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ func New{{.ResultSetName}}(rs kallax.ResultSet) *{{.ResultSetName}} {
1919
func (rs *{{.ResultSetName}}) Next() bool {
2020
if !rs.ResultSet.Next() {
2121
rs.lastErr = rs.ResultSet.Close()
22+
rs.last = nil
2223
return false
2324
}
2425

tests/kallax.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,6 +356,7 @@ func NewCarResultSet(rs kallax.ResultSet) *CarResultSet {
356356
func (rs *CarResultSet) Next() bool {
357357
if !rs.ResultSet.Next() {
358358
rs.lastErr = rs.ResultSet.Close()
359+
rs.last = nil
359360
return false
360361
}
361362

@@ -735,6 +736,7 @@ func NewEventsFixtureResultSet(rs kallax.ResultSet) *EventsFixtureResultSet {
735736
func (rs *EventsFixtureResultSet) Next() bool {
736737
if !rs.ResultSet.Next() {
737738
rs.lastErr = rs.ResultSet.Close()
739+
rs.last = nil
738740
return false
739741
}
740742

@@ -1106,6 +1108,7 @@ func NewEventsSaveFixtureResultSet(rs kallax.ResultSet) *EventsSaveFixtureResult
11061108
func (rs *EventsSaveFixtureResultSet) Next() bool {
11071109
if !rs.ResultSet.Next() {
11081110
rs.lastErr = rs.ResultSet.Close()
1111+
rs.last = nil
11091112
return false
11101113
}
11111114

@@ -1465,6 +1468,7 @@ func NewMultiKeySortFixtureResultSet(rs kallax.ResultSet) *MultiKeySortFixtureRe
14651468
func (rs *MultiKeySortFixtureResultSet) Next() bool {
14661469
if !rs.ResultSet.Next() {
14671470
rs.lastErr = rs.ResultSet.Close()
1471+
rs.last = nil
14681472
return false
14691473
}
14701474

@@ -1987,6 +1991,7 @@ func NewPersonResultSet(rs kallax.ResultSet) *PersonResultSet {
19871991
func (rs *PersonResultSet) Next() bool {
19881992
if !rs.ResultSet.Next() {
19891993
rs.lastErr = rs.ResultSet.Close()
1994+
rs.last = nil
19901995
return false
19911996
}
19921997

@@ -2419,6 +2424,7 @@ func NewPetResultSet(rs kallax.ResultSet) *PetResultSet {
24192424
func (rs *PetResultSet) Next() bool {
24202425
if !rs.ResultSet.Next() {
24212426
rs.lastErr = rs.ResultSet.Close()
2427+
rs.last = nil
24222428
return false
24232429
}
24242430

@@ -2770,6 +2776,7 @@ func NewQueryFixtureResultSet(rs kallax.ResultSet) *QueryFixtureResultSet {
27702776
func (rs *QueryFixtureResultSet) Next() bool {
27712777
if !rs.ResultSet.Next() {
27722778
rs.lastErr = rs.ResultSet.Close()
2779+
rs.last = nil
27732780
return false
27742781
}
27752782

@@ -3121,6 +3128,7 @@ func NewResultSetFixtureResultSet(rs kallax.ResultSet) *ResultSetFixtureResultSe
31213128
func (rs *ResultSetFixtureResultSet) Next() bool {
31223129
if !rs.ResultSet.Next() {
31233130
rs.lastErr = rs.ResultSet.Close()
3131+
rs.last = nil
31243132
return false
31253133
}
31263134

@@ -3582,6 +3590,7 @@ func NewSchemaFixtureResultSet(rs kallax.ResultSet) *SchemaFixtureResultSet {
35823590
func (rs *SchemaFixtureResultSet) Next() bool {
35833591
if !rs.ResultSet.Next() {
35843592
rs.lastErr = rs.ResultSet.Close()
3593+
rs.last = nil
35853594
return false
35863595
}
35873596

@@ -3933,6 +3942,7 @@ func NewStoreFixtureResultSet(rs kallax.ResultSet) *StoreFixtureResultSet {
39333942
func (rs *StoreFixtureResultSet) Next() bool {
39343943
if !rs.ResultSet.Next() {
39353944
rs.lastErr = rs.ResultSet.Close()
3945+
rs.last = nil
39363946
return false
39373947
}
39383948

@@ -4284,6 +4294,7 @@ func NewStoreWithConstructFixtureResultSet(rs kallax.ResultSet) *StoreWithConstr
42844294
func (rs *StoreWithConstructFixtureResultSet) Next() bool {
42854295
if !rs.ResultSet.Next() {
42864296
rs.lastErr = rs.ResultSet.Close()
4297+
rs.last = nil
42874298
return false
42884299
}
42894300

@@ -4639,6 +4650,7 @@ func NewStoreWithNewFixtureResultSet(rs kallax.ResultSet) *StoreWithNewFixtureRe
46394650
func (rs *StoreWithNewFixtureResultSet) Next() bool {
46404651
if !rs.ResultSet.Next() {
46414652
rs.lastErr = rs.ResultSet.Close()
4653+
rs.last = nil
46424654
return false
46434655
}
46444656

0 commit comments

Comments
 (0)