fix debug for inserts and deletes, return error for models with no fields

Author: Miguel Molina

common_test.go

@@ -182,6 +182,44 @@ func (m *rel) SetRelationship(field string, record interface{}) error {
 	return fmt.Errorf("kallax: no relationship found for field %s", field)
 }
 
+type onlyPkModel struct {
+	Model
+	ID int64 `pk:"autoincr"`
+}
+
+func newOnlyPkModel() *onlyPkModel {
+	m := new(onlyPkModel)
+	return m
+}
+
+func (m *onlyPkModel) Value(col string) (interface{}, error) {
+	switch col {
+	case "id":
+		return m.ID, nil
+	}
+	return nil, fmt.Errorf("kallax: column does not exist: %s", col)
+}
+
+func (m *onlyPkModel) ColumnAddress(col string) (interface{}, error) {
+	switch col {
+	case "id":
+		return &m.ID, nil
+	}
+	return nil, fmt.Errorf("kallax: column does not exist: %s", col)
+}
+
+func (m *onlyPkModel) NewRelationshipRecord(field string) (Record, error) {
+	return nil, fmt.Errorf("kallax: no relationship found for field %s", field)
+}
+
+func (m *onlyPkModel) SetRelationship(field string, record interface{}) error {
+	return fmt.Errorf("kallax: no relationship found for field %s", field)
+}
+
+func (m *onlyPkModel) GetID() Identifier {
+	return (*NumericID)(&m.ID)
+}
+
 var ModelSchema = NewBaseSchema(
 	"model",
 	"__model",
@@ -215,6 +253,18 @@ var RelSchema = NewBaseSchema(
 	f("foo"),
 )
 
+var onlyPkModelSchema = NewBaseSchema(
+	"model",
+	"__model",
+	f("id"),
+	nil,
+	func() Record {
+		return new(onlyPkModel)
+	},
+	true,
+	f("id"),
+)
+
 func f(name string) SchemaField {
 	return NewSchemaField(name)
 }

generator/cli/kallax/cmd.go

@@ -8,7 +8,7 @@ import (
 	"gopkg.in/urfave/cli.v1"
 )
 
-const version = "1.2.1"
+const version = "1.2.2"
 
 func main() {
 	newApp().Run(os.Args)

store.go

@@ -32,6 +32,9 @@ var (
 	// neither an autoincrement primary key nor implements the IDSetter
 	// interface.
 	ErrCantSetID = errors.New("kallax: model does not have an auto incrementable primary key, it needs to implement IDSetter interface")
+	// ErrNoColumns is an error returned when the user tries to insert a model
+	// with no other columns than the autoincrementable primary key.
+	ErrNoColumns = errors.New("kallax: your model does not have any column besides its autoincrementable primary key and cannot be inserted")
 )
 
 // GenericStorer is a type that contains a generic store and has methods to
@@ -123,10 +126,11 @@ func (s *Store) Debug() *Store {
 // DebugWith returns a new store that will print all SQL statements using the
 // given logger function.
 func (s *Store) DebugWith(logger LoggerFunc) *Store {
+	proxy := &debugProxy{logger, s.proxy}
 	return &Store{
-		builder: s.builder,
+		builder: s.builder.RunWith(proxy),
 		db:      s.db,
-		proxy:   &debugProxy{logger, s.proxy},
+		proxy:   proxy,
 	}
 }
 
@@ -145,6 +149,10 @@ func (s *Store) Insert(schema Schema, record Record) error {
 		cols = cols[1:]
 	}
 
+	if len(cols) == 0 {
+		return ErrNoColumns
+	}
+
 	values, err := RecordValues(record, cols...)
 	if err != nil {
 		return err

store_test.go

@@ -61,6 +61,11 @@ func (s *StoreSuite) TestInsert_IDEmpty() {
 	s.False(m.GetID().IsEmpty())
 }
 
+func (s *StoreSuite) TestInsert_NoColumns() {
+	var m = new(onlyPkModel)
+	s.Equal(ErrNoColumns, s.store.Insert(onlyPkModelSchema, m))
+}
+
 func (s *StoreSuite) TestUpdate() {
 	var m = newModel("a", "[email protected]", 1)
 	s.NoError(s.store.Insert(ModelSchema, m))