don't show + button on list widget when showing all notes

Author: CampelloManuel

app/src/main/java/com/nononsenseapps/notepad/widget/list/ListWidgetConfig.java

@@ -354,9 +354,10 @@ public void onLoaderReset(@NonNull Loader<Cursor> l) {
 	}
 
 	/**
-	 * Calling {@link SimpleWidgetPreviewAdapter#notifyDataSetChanged} on {@link #mNotesAdapter}
-	 * can only refresh the views, but it doesn't change the cursor, so it can't toggle between
-	 * "do/dont show completed notes". This function can, because it updates the underlying cursor
+	 * Calling {@link SimpleWidgetPreviewAdapter#notifyDataSetChanged} on
+	 * {@link #mNotesAdapter} can only refresh the views, but it doesn't change the
+	 * cursor, so it can't toggle between "do/dont show completed notes". This function
+	 * can, because it updates the underlying cursor
 	 */
 	void reloadTasks() {
 		LoaderManager.getInstance(this).restartLoader(0, null, mCallback);

app/src/main/java/com/nononsenseapps/notepad/widget/list/ListWidgetProvider.java

@@ -231,6 +231,7 @@ public static RemoteViews buildRemoteViews(final Context context,
 		PendingIntent openConfigPendingIntent = getThePendingIntentForActivity(configIntent, context);
 		rv.setOnClickPendingIntent(R.id.widgetConfigButton, openConfigPendingIntent);
 
+		// + button to create a new note from the widget
 		final Intent createIntent = new Intent();
 		createIntent
 				.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK)
@@ -240,8 +241,15 @@ public static RemoteViews buildRemoteViews(final Context context,
 				.setData(Uri.withAppendedPath(Task.URI, "/widget/" + appWidgetId + "/-1"))
 				.putExtra(TaskDetailFragment.ARG_ITEM_LIST_ID, listId);
 
-		PendingIntent createPendingIntent = getThePendingIntentForActivity(createIntent, context);
-		rv.setOnClickPendingIntent(R.id.createNoteButton, createPendingIntent);
+		if (listId > 0) {
+			rv.setViewVisibility(R.id.createNoteButton, View.VISIBLE);
+			PendingIntent createPendingIntent = getThePendingIntentForActivity(createIntent, context);
+			rv.setOnClickPendingIntent(R.id.createNoteButton, createPendingIntent);
+		} else {
+			// the widget is showing notes from all lists: hide the + button,
+			// because it would not find a valid list to add a note to
+			rv.setViewVisibility(R.id.createNoteButton, View.GONE);
+		}
 
 		return rv;
 	}