Skip to content

Conversation

@ssfdre38
Copy link

adding where port is at in the source code for port change if needed

adding where port is at in the source code for port change if needed
@MathMan05
Copy link
Contributor

Please just set the env
image

@ssfdre38
Copy link
Author

Multiple applications require port 8080 this way if somebody wants to change the port without having to change the environmental settings every single time that they are trying to launch the application or test run, this way they can without having to set it every single time

@MathMan05
Copy link
Contributor

image

@TheArcaneBrony
Copy link
Member

Consider: systemd can do this for you anyways, just add this to your service file:

Environment=PORT=8081

@ssfdre38
Copy link
Author

i know it can be done this way as well but for some people like me, we are working on customize it and changing it that way helps to just run the client without having to add it to the startup or an env.

@TheArcaneBrony
Copy link
Member

Then that's... on you?
Just add the env var and forget about it, it's a single line in your systemd service lol - the docs dont cover modifying the source code of documented applications for a reason. You're just adding more maintenance overhead to your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants