I added a Pushover notifier to my checks recently and noticed just how flaky they are. By default I have a check which makes 5 attempts. If just one of the attempts fails (e.g. TLS handshake timeout) then boom the whole site is marked down, even if the other 4 work fine.
Would it be possible to consider a configuration option of allowed failed attempts?
Here's the code which configures at-least-one-error-means-down:
|
// Check errors (down) |
|
for i := range result.Times { |
|
if result.Times[i].Error != "" { |
|
result.Down = true |
|
return result |
|
} |
|
} |
I added a Pushover notifier to my checks recently and noticed just how flaky they are. By default I have a check which makes 5 attempts. If just one of the attempts fails (e.g. TLS handshake timeout) then boom the whole site is marked down, even if the other 4 work fine.
Would it be possible to consider a configuration option of allowed failed attempts?
Here's the code which configures at-least-one-error-means-down:
checkup/check/http/http.go
Lines 151 to 157 in cdc8b78