Pytest problem Lesson 7

[Cesarioo]

Hi, I have a small issue here when running my tets
here is the code:

and this code reverts this:

whereas the line exceptions should turn the test green

I've tried everything, even copy pasted Patrick's code directly in my VSCode
Thanks a lot

[cromewar]

Hello @Cesarioo
This happens when you make a change to your contract (typically add a new method) but fail to deploy the contract to the network. so please delete the build folder and compile again with brownie compile. Also this error comes from the contract, so please verify if you have any typo on Lottery.sol, if you want post it in here and I'll help you to check it.

[PatrickAlphaC]

Hmm... Thanks for the flag. What is the command you're using to run this? You could also try exceptions.ValueError... maybe brownie updated some codes...

[ZeroEkkusu]

Seems to be an issue when testing on local Ganache. By making some intentional errors in code, I can get the other networks to give me VirtualMachineError, but would always get ValueError with the GUI Ganache (I'm on Lesson 6, btw)
My temporary solution is

e = ValueError if network.show_active() == "ganache-local" else exceptions.VirtualMachineError
with pytest.raises(e):
       #...

Let me know if you've found a better one

[cromewar]

@Cesarioo try @ZeroEkkusu solution ;)

[Cesarioo]

Yes, it works ! Thanks a lot friends !

[Cesarioo]

Also an other question: is it normal that my tests take up to 50sec to pass when Patrick's takes only 3sec ?

[ZeroEkkusu]

So, the issue is with the GUI Ganache. I've found a few similar issues reported on the repo, as well. Until it gets fixed (or we find what we're doing wrong 😉), you can do

ex = ValueError if network.show_active(
) == "ganache-local" else exceptions.VirtualMachineError
with pytest.raises(ex):
        # ...

Another solution is

with pytest.raises(exceptions.VirtualMachineError):
    lottery.enter(
        {"from": get_account(), "value": lottery.getEntranceFee(), "gas_limit": 100000, "allow_revert": True})

As for the testing times, this is what I get in Lesson 7:
brownie test --network development 00:05
brownie test --network ganache-local 00:08
Testing on an actual testnet takes much longer and times may vary by quite a lot

P.S. A better title would be Getting a ValueError instead of VirtualMachineError when using pytest.raises(), so that others who face the same problem in the future can find this discussion easily

[cromewar]

You are just awesome @ZeroEkkusu.