NONEVM-2403: TON CLDF clean up #585
Conversation
🦋 Changeset detectedLatest commit: 3364f9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the TON chain integration by reverting the APIClient type change, refactoring CTF provider methods to return errors instead of using test assertions, and removing retry configuration from the provider layer to enable more flexible chain type extensions.
Key changes:
- Reverted
Clientfield type fromton.APIClientWrappedto*ton.APIClient - Refactored CTF provider helper methods to return errors for better testability
- Removed
RetryCountconfiguration option from both RPC and CTF providers
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| chain/ton/ton_chain.go | Reverted Client field type to *ton.APIClient |
| chain/ton/provider/rpc_provider.go | Removed RetryCount config and related logic from RPC provider |
| chain/ton/provider/rpc_provider_test.go | Removed tests for RetryCount configuration |
| chain/ton/provider/ctf_provider.go | Refactored helper methods to return errors; removed retry config; fixed typos |
| chain/ton/provider/ctf_provider_test.go | Updated test assertion for corrected provider name |
| .changeset/curvy-berries-film.md | Added changeset documenting the cleanup |
Comments suppressed due to low confidence (1)
chain/ton/provider/ctf_provider.go:2
- The helper functions still use
ton.APIClientWrappedas the client parameter type, but the PR reverts the chain's Client field to*ton.APIClient. This type mismatch will cause compilation errors when these functions are called with the chain's client. The client parameter types should be changed to*ton.APIClientto match the reverted type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| func createTonWallet(t *testing.T, client ton.APIClientWrapped, versionConfig wallet.VersionConfig, option wallet.Option) *wallet.Wallet { | ||
| t.Helper() | ||
|
|
||
| func createTonWallet(client ton.APIClientWrapped, versionConfig wallet.VersionConfig, option wallet.Option) (*wallet.Wallet, error) { |
There was a problem hiding this comment.
The helper functions still use ton.APIClientWrapped as the client parameter type, but the PR reverts the chain's Client field to *ton.APIClient. This type mismatch will cause compilation errors when these functions are called with the chain's client. The client parameter types should be changed to *ton.APIClient to match the reverted type.
There was a problem hiding this comment.
ton.APIClientWrapped is an interface from the tonutils-go library, *ton.APIClient implements this interface
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - [#586](#586) [`f3a2a36`](f3a2a36) Thanks [@jkongie](https://github.com/jkongie)! - Updates Test Engine Sui container to use a specific devnet image and generate different deploy keys for each container ### Patch Changes - [#585](#585) [`7760d13`](7760d13) Thanks [@jadepark-dev](https://github.com/jadepark-dev)! - Clean up TON CTF Provider, update test infra methods --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
2 participants
*ton.APIClienttype change