Skip to content

bugfix: resolve broke form styling #4091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 14, 2025
Merged

bugfix: resolve broke form styling #4091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4e09404
Resolve broke from styling
endigo9740 Nov 11, 2025
8ecee1e
Form element bugfix documented for next release
endigo9740 Nov 12, 2025
fc6925b
Add Forms plugin to Docs app; small style corrections
endigo9740 Nov 13, 2025
dd15d56
Added changeset
endigo9740 Nov 13, 2025
6ee8a6a
Merge branch 'main' into bugfix/resolve-form-styles
endigo9740 Nov 13, 2025
36560c1
Windows bugfix updated for input groups
endigo9740 Nov 14, 2025
5aa50e0
Merge branch 'main' into bugfix/resolve-form-styles
endigo9740 Nov 14, 2025
5508c84
Typo
endigo9740 Nov 14, 2025
6597bea
Merge
endigo9740 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/six-socks-hammer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@skeletonlabs/skeleton": patch
---

bugfix: Resolved style issues for Select, Radio, Checkbox utilities

5 changes: 0 additions & 5 deletions packages/skeleton/src/utilities/form-groups.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,6 @@
& option {
background-color: var(--color-surface-50-950);
color: var(--color-surface-950-50);
border-radius: var(--radius-base);
font-size: var(--text-base);
line-height: --spacing(9);
height: --spacing(9);
padding: --spacing(2);
}
}

Expand Down
18 changes: 18 additions & 0 deletions packages/skeleton/src/utilities/form-radios-checks.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
/* Components: Forms > Radio / Checkbox */

/*
NOTE:
`background-color` is used when the Forms plugin is present.
`accent-color` is a fallback when the Forms plugin is missing.
It's recommended to use the Forms plugin for cross-browser consistency.
*/

@utility checkbox {
--tw-ring-color: var(--color-surface-200-800);

cursor: pointer;
background-color: var(--color-surface-300-700);
accent-color: var(--color-surface-300-700);
border-radius: var(--radius-sm);
height: --spacing(5);
width: --spacing(5);
Expand All @@ -21,24 +29,30 @@

&:checked {
background-color: var(--color-primary-500);
accent-color: var(--color-primary-500);

@variant hover {
background-color: var(--color-primary-500);
accent-color: var(--color-primary-500);
}
@variant focus {
background-color: var(--color-primary-500);
accent-color: var(--color-primary-500);
border: 0;
}
}

&:indeterminate {
background-color: var(--color-primary-500);
accent-color: var(--color-primary-500);

@variant hover {
background-color: var(--color-primary-500);
accent-color: var(--color-primary-500);
}
@variant focus {
background-color: var(--color-primary-500);
accent-color: var(--color-primary-500);
border: 0;
}
}
Expand All @@ -49,6 +63,7 @@

cursor: pointer;
background-color: var(--color-surface-300-700);
accent-color: var(--color-surface-300-700);
border-radius: var(--radius-sm);
height: --spacing(5);
width: --spacing(5);
Expand All @@ -70,12 +85,15 @@

&:checked {
background-color: var(--color-primary-500);
accent-color: var(--color-primary-500);

@variant hover {
background-color: var(--color-primary-500);
accent-color: var(--color-primary-500);
}
@variant focus {
background-color: var(--color-primary-500);
accent-color: var(--color-primary-500);
border: 0;
}
}
Expand Down
5 changes: 0 additions & 5 deletions packages/skeleton/src/utilities/form-selects.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,5 @@
& option {
background-color: var(--color-surface-50-950);
color: var(--color-surface-950-50);
border-radius: var(--radius-base);
font-size: var(--text-base);
line-height: --spacing(9);
height: --spacing(9);
padding: --spacing(2);
}
}
11 changes: 7 additions & 4 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions sites/skeleton.dev/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"@skeletonlabs/skeleton-react": "workspace:*",
"@skeletonlabs/skeleton-svelte": "workspace:*",
"@stackblitz/sdk": "catalog:",
"@tailwindcss/forms": "catalog:",
"@tailwindcss/vite": "catalog:",
"@types/html-escaper": "catalog:",
"@types/mdast": "catalog:",
Expand Down
17 changes: 17 additions & 0 deletions sites/skeleton.dev/src/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
@import 'tailwindcss';
@plugin '@tailwindcss/forms';

/* Skeleton */
@import '@skeletonlabs/skeleton';
@import '@skeletonlabs/skeleton-svelte';
@import '@skeletonlabs/skeleton-react';

/* Skeleton Themes */
@import '@skeletonlabs/skeleton/themes/catppuccin';
@import '@skeletonlabs/skeleton/themes/cerberus';
@import '@skeletonlabs/skeleton/themes/concord';
Expand Down Expand Up @@ -112,3 +117,15 @@ html {
.spin-360 {
animation: spin 5s linear infinite; /* Shorthand */
}

/* Temporary Bugfix */
/* https://github.com/skeletonlabs/skeleton/issues/3993 */
/* Remove these bugfix styles in Skeleton v5+ */
.select,
.input,
.textarea,
.ig-input,
.ig-select {
background-color: var(--color-surface-50-950);
color: var(--color-surface-950-50);
}
15 changes: 15 additions & 0 deletions sites/skeleton.dev/src/content/docs/tailwind-components/forms.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,21 @@ Then implement in your global stylesheet using the the `@plugin` directive.
/* ...Skeleton config here... */
```

### Windows Bugfix

To avoid a [breaking style issue in Windows-based browsers](https://github.com/skeletonlabs/skeleton/issues/3993), it's recommended you include this temporary fix into your global stylesheet. Please note this change will be automatically and permanently applied for you in Skeleton v5+.

```css
.select,
.input,
.textarea,
.ig-input,
.ig-select {
background-color: var(--color-surface-50-950);
color: var(--color-surface-950-50);
}
```

### Browser Support

The quality and appearance of native and semantic HTML form elements can vary between both operating systems and browser vendors. Skeleton does its best to adhere to progressive enhancement best practices. However, we advise you validate support for each element per your target audience.
Expand Down