Merge pull request #14 from sendgrid/891-async-fix

#9 async fix

Author: thinkingserious

CSharpHTTPClient/CSharpHTTPClient.csproj

@@ -45,9 +45,6 @@
   <ItemGroup>
     <Reference Include="System" />
     <Reference Include="System.Core" />
-    <Reference Include="System.Net.Http.Formatting">
-      <HintPath>..\..\sendgrid-csharp\SendGrid\SendGrid\bin\Debug\System.Net.Http.Formatting.dll</HintPath>
-    </Reference>
     <Reference Include="System.Web" />
     <Reference Include="System.Web.Extensions" />
     <Reference Include="System.Xml.Linq" />

CSharpHTTPClient/Client.cs

@@ -280,7 +280,7 @@ public override bool TryInvokeMember(InvokeMemberBinder binder, object[] args, o
                     }
                     i++;
                 }
-                result = RequestAsync(binder.Name.ToUpper(), requestBody: requestBody, queryParams: queryParams).Result;
+                result = RequestAsync(binder.Name.ToUpper(), requestBody: requestBody, queryParams: queryParams).ConfigureAwait(false);
                 return true;
             }
             else

Example/Example.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using SendGrid.CSharp.HTTP.Client;
 using System.Web.Script.Serialization;
+using System.Threading.Tasks;
 using Newtonsoft.Json;
 
 // This is a working example, using the SendGrid API
@@ -12,6 +13,11 @@ namespace Example
     class Example
     {
         static void Main(string[] args)
+        {
+            Execute().Wait();
+        }
+
+        static async Task Execute()
         {
             String host = "https://e9sk3d3bfaikbpdq7.stoplight-proxy.io";
             Dictionary<String, String> globalRequestHeaders = new Dictionary<String, String>();
@@ -28,23 +34,11 @@ static void Main(string[] args)
             }";
             Dictionary<String, String> requestHeaders = new Dictionary<String, String>();
             requestHeaders.Add("X-Test", "test");
-            dynamic response = client.api_keys.get(queryParams: queryParams, requestHeaders: requestHeaders);
+            dynamic response = await client.api_keys.get(queryParams: queryParams, requestHeaders: requestHeaders);
             Console.WriteLine(response.StatusCode);
             Console.WriteLine(response.Body.ReadAsStringAsync().Result);
             Console.WriteLine(response.Headers.ToString());
 
-            var dssResponseBody = response.DeserializeResponseBody(response.Body);
-            foreach ( var value in dssResponseBody["result"])
-            {
-                Console.WriteLine("name: {0}, api_key_id: {1}",value["name"], value["api_key_id"]);
-            }
-
-            var dssResponseHeaders = response.DeserializeResponseHeaders(response.Headers);
-            foreach (var pair in dssResponseHeaders)
-            {
-                Console.WriteLine("{0}: {1}", pair.Key, pair.Value);
-            }
-
             Console.WriteLine("\n\nPress any key to continue to POST.");
             Console.ReadLine();
 
@@ -60,7 +54,7 @@ static void Main(string[] args)
             Object json = JsonConvert.DeserializeObject<Object>(requestBody);
             requestHeaders.Clear();
             requestHeaders.Add("X-Test", "test2");
-            response = client.api_keys.post(requestBody: json.ToString(), requestHeaders: requestHeaders);
+            response = await client.api_keys.post(requestBody: json.ToString(), requestHeaders: requestHeaders);
             Console.WriteLine(response.StatusCode);
             Console.WriteLine(response.Body.ReadAsStringAsync().Result);
             Console.WriteLine(response.Headers.ToString());
@@ -72,7 +66,7 @@ static void Main(string[] args)
             Console.ReadLine();
 
             // GET Single
-            response = client.api_keys._(api_key_id).get();
+            response = await client.api_keys._(api_key_id).get();
             Console.WriteLine(response.StatusCode);
             Console.WriteLine(response.Body.ReadAsStringAsync().Result);
             Console.WriteLine(response.Headers.ToString());
@@ -85,7 +79,7 @@ static void Main(string[] args)
                 'name': 'A New Hope'
             }";
             json = JsonConvert.DeserializeObject<Object>(requestBody);
-            response = client.api_keys._(api_key_id).patch(requestBody: json.ToString());
+            response = await client.api_keys._(api_key_id).patch(requestBody: json.ToString());
             Console.WriteLine(response.StatusCode);
             Console.WriteLine(response.Body.ReadAsStringAsync().Result);
             Console.WriteLine(response.Headers.ToString());
@@ -102,7 +96,7 @@ static void Main(string[] args)
                 ]
             }";
             json = JsonConvert.DeserializeObject<Object>(requestBody);
-            response = client.api_keys._(api_key_id).put(requestBody: json.ToString());
+            response = await client.api_keys._(api_key_id).put(requestBody: json.ToString());
             Console.WriteLine(response.StatusCode);
             Console.WriteLine(response.Body.ReadAsStringAsync().Result);
             Console.WriteLine(response.Headers.ToString());
@@ -111,7 +105,7 @@ static void Main(string[] args)
             Console.ReadLine();
 
             // DELETE
-            response = client.api_keys._(api_key_id).delete();
+            response = await client.api_keys._(api_key_id).delete();
             Console.WriteLine(response.StatusCode);
             Console.WriteLine(response.Headers.ToString());
 

README.md

@@ -40,7 +40,7 @@ Here is a quick example:
 using SendGrid.CSharp.HTTP.Client;
 globalRequestHeaders.Add("Authorization", "Bearer XXXXXXX");
 dynamic client = new Client(host: baseUrl, requestHeaders: globalRequestHeaders);
-client.your.api._(param).call.get()
+var response = await client.your.api._(param).call.get()
 Console.WriteLine(response.StatusCode);
 Console.WriteLine(response.Body.ReadAsStringAsync().Result);
 Console.WriteLine(response.Headers.ToString());
@@ -57,7 +57,7 @@ string queryParams = @"{'Hello': 0, 'World': 1}";
 requestHeaders.Add("X-Test", "test");
 string requestBody = @"{'some': 1, 'awesome': 2, 'data': 3}";
 Object json = JsonConvert.DeserializeObject<Object>(requestBody);
-var response = client.your.api._(param).call.post(requestBody: json.ToString(),
+var response = await client.your.api._(param).call.post(requestBody: json.ToString(),
                                                   queryParams: queryParams,
                                                   requestHeaders: requestHeaders)
 Console.WriteLine(response.StatusCode);

UnitTest/UnitTest.cs

@@ -64,11 +64,11 @@ public void TestReflection()
         }
 
         [Test]
-        public void TestMethodCall()
+        public async void TestMethodCall()
         {
             var host = "http://api.test.com";
             dynamic test_client = new MockClient(host: host);
-            Response response = test_client.get();
+            Response response = await test_client.get();
             Assert.IsNotNull(response);
             Assert.AreEqual(response.StatusCode, HttpStatusCode.OK);
             var content = new StringContent("{'test': 'test_content'}", Encoding.UTF8, "application/json");