Merge pull request #352 from seleniumbase/w3c-support

Adding w3c Chromedriver support

Author: mdmintz

seleniumbase/console_scripts/sb_install.py

@@ -71,11 +71,11 @@ def main():
     inner_folder = None
 
     if name == "chromedriver":
-        latest_version = "2.46"
+        latest_version = "2.44"  # It's not the latest, but most compatible
         if "darwin" in sys_plat:
             file_name = "chromedriver_mac64.zip"
         elif "linux" in sys_plat:
-            latest_version = "2.40"  # Linux machines may need the old driver
+            latest_version = "2.44"  # Linux machines may need the old driver
             file_name = "chromedriver_linux64.zip"
         elif "win32" in sys_plat or "win64" in sys_plat or "x64" in sys_plat:
             file_name = "chromedriver_win32.zip"  # Works for win32 / win_x64

seleniumbase/core/browser_launcher.py

@@ -109,6 +109,7 @@ def _set_chrome_options(
         }
     }
     chrome_options.add_experimental_option("prefs", prefs)
+    chrome_options.add_experimental_option("w3c", True)
     if enable_sync:
         chrome_options.add_experimental_option(
             "excludeSwitches", ["disable-sync"])

seleniumbase/fixtures/js_utils.py

@@ -592,7 +592,12 @@ def highlight_with_jquery_2(driver, message, selector, o_bs, msg_dur):
 
 
 def scroll_to_element(driver, element):
-    element_location = element.location['y']
+    element_location = None
+    try:
+        element_location = element.location['y']
+    except Exception:
+        element.location_once_scrolled_into_view
+        return
     element_location = element_location - 130
     if element_location < 0:
         element_location = 0
@@ -611,7 +616,12 @@ def slow_scroll_to_element(driver, element, browser):
         scroll_to_element(driver, element)
         return
     scroll_position = driver.execute_script("return window.scrollY;")
-    element_location = element.location['y']
+    element_location = None
+    try:
+        element_location = element.location['y']
+    except Exception:
+        element.location_once_scrolled_into_view
+        return
     element_location = element_location - 130
     if element_location < 0:
         element_location = 0

setup.py

@@ -17,7 +17,7 @@
 
 setup(
     name='seleniumbase',
-    version='1.26.3',
+    version='1.26.4',
     description='Fast, Easy, and Reliable Browser Automation & Testing.',
     long_description=long_description,
     long_description_content_type='text/markdown',