Merge pull request #467 from seleniumbase/prevent-unused-log-folders-from-getting-created

Prevent unused log folders from getting created

Author: mdmintz

README.md

@@ -1,4 +1,3 @@
-
 [<img src="https://cdn2.hubspot.net/hubfs/100006/images/super_logo_sb20.png" title="SeleniumBase" height="48">](https://github.com/seleniumbase/SeleniumBase/blob/master/README.md)
 
 [<img src="https://img.shields.io/github/release/seleniumbase/SeleniumBase.svg" alt=" " />](https://github.com/seleniumbase/SeleniumBase/releases) [<img src="https://img.shields.io/pypi/v/seleniumbase.svg" alt=" " />](https://pypi.python.org/pypi/seleniumbase) [<img src="https://badges.gitter.im/seleniumbase/SeleniumBase.svg" alt=" " />](https://gitter.im/seleniumbase/SeleniumBase) [<img src="https://img.shields.io/travis/seleniumbase/SeleniumBase/master.svg?logo=travis" alt=" " />](https://travis-ci.org/seleniumbase/SeleniumBase) [<img src="https://dev.azure.com/seleniumbase/seleniumbase/_apis/build/status/seleniumbase.SeleniumBase?branchName=master" alt=" " />](https://dev.azure.com/seleniumbase/seleniumbase/_build/latest?definitionId=1&branchName=master) [<img src="https://github.com/seleniumbase/SeleniumBase/workflows/CI%20build/badge.svg">](https://github.com/seleniumbase/SeleniumBase/actions) [<img src="https://img.shields.io/badge/license-MIT-22BBCC.svg" alt=" " />](https://github.com/seleniumbase/SeleniumBase/blob/master/LICENSE) [<img src="https://img.shields.io/github/stars/seleniumbase/seleniumbase.svg" alt=" " />](https://github.com/seleniumbase/SeleniumBase/stargazers)

seleniumbase/fixtures/base_case.py

@@ -4453,10 +4453,10 @@ def save_teardown_screenshot(self):
             will still be taken after the last step of your tearDown(), where
             you should be calling "super(SubClassOfBaseCase, self).tearDown()"
         """
-        test_id = self.__get_test_id()
-        test_logpath = self.log_path + "/" + test_id
-        self.__create_log_path_as_needed(test_logpath)
         if self.__has_exception() or self.save_screenshot_after_test:
+            test_id = self.__get_test_id()
+            test_logpath = self.log_path + "/" + test_id
+            self.__create_log_path_as_needed(test_logpath)
             self.__set_last_page_screenshot()
             if self.is_pytest:
                 self.__add_pytest_html_extra()

setup.py

@@ -45,7 +45,7 @@
 
 setup(
     name='seleniumbase',
-    version='1.34.14',
+    version='1.34.15',
     description='Fast, Easy, and Reliable Browser Automation & Testing.',
     long_description=long_description,
     long_description_content_type='text/markdown',