Skip to content

Commit 867fb0c

Browse files
committed
fix: rename release.yml to publish.yml to match npm trusted publisher
npm's OIDC trusted-publisher config for these packages was already registered against a workflow file named publish.yml, not release.yml - renaming to match avoids a per-package re-registration.
1 parent 56dfc4d commit 867fb0c

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

RELEASING.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -83,14 +83,15 @@ Feature branches are automatically released under:
8383

8484
## NPM Publishing
8585

86-
Publishing runs on GitHub Actions (`.github/workflows/release.yml`), triggered by a
86+
Publishing runs on GitHub Actions (`.github/workflows/publish.yml`), triggered by a
8787
"Version Packages" merge to `master`. There is **no stored `NPM_TOKEN` secret**
8888
publish authenticates via npm's **OIDC trusted publishing**, a short-lived,
8989
per-run token minted automatically for the `production`-environment-gated
9090
`publish` job.
9191

9292
Each of the 7 published `@segment/*` packages has its own npm **trusted publisher**
93-
registration (repo + `release.yml` + `production` environment) — set up once on
94-
npmjs.org per package, not something rotated. If npm ever requires re-registering a
95-
trusted publisher (e.g. the workflow filename changes), do it in the npmjs.org UI
96-
for each package under Settings → Trusted Publisher.
93+
registration (repo + `publish.yml` + `production` environment) — set up once on
94+
npmjs.org per package, not something rotated. If the workflow filename ever changes
95+
again, either rename the workflow to match the existing registration, or
96+
re-register the trusted publisher in the npmjs.org UI for each package under
97+
Settings → Trusted Publisher — whichever is already correct is the one to keep.

0 commit comments

Comments
 (0)