Merge pull request #168 from North-Two-Five/issue#167-Events-not-sent-to-Segment-servers-Failed-to-send-analytic-event

pooyaj · web-flow · commit 779e70598224 · 2021-05-12T10:38:36.000-07:00
Issue#167 events not sent to segment servers failed to send analytic event
diff --git a/Analytics/Request/BlockingRequestHandler.cs b/Analytics/Request/BlockingRequestHandler.cs
@@ -152,7 +152,7 @@ internal BlockingRequestHandler(Client client, TimeSpan timeout, HttpClient http
         public async Task MakeRequest(Batch batch)
         {
             Stopwatch watch = new Stopwatch();
-
+            _backo.Reset();
             try
             {
                 Uri uri = new Uri(_client.Config.Host + "/v1/import");
@@ -346,10 +346,6 @@ public async Task MakeRequest(Batch batch)
                 {
                     var message = $"Has Backoff reached max: {hasBackoReachedMax} with number of Attempts:{_backo.CurrentAttempt},\n Status Code: {statusCode}\n, response message: {responseStr}";
                     Fail(batch, new APIException(statusCode.ToString(), message), watch.ElapsedMilliseconds);
-                    if (_backo.HasReachedMax)
-                    {
-                        _backo.Reset();
-                    }
                 }
             }
             catch (System.Exception e)

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ internal BlockingRequestHandler(Client client, TimeSpan timeout, HttpClient http`
`152`	`152`	`public async Task MakeRequest(Batch batch)`
`153`	`153`	`{`
`154`	`154`	`Stopwatch watch = new Stopwatch();`
`155`		`-`
	`155`	`+ _backo.Reset();`
`156`	`156`	`try`
`157`	`157`	`{`
`158`	`158`	`Uri uri = new Uri(_client.Config.Host + "/v1/import");`
`@@ -346,10 +346,6 @@ public async Task MakeRequest(Batch batch)`
`346`	`346`	`{`
`347`	`347`	`var message = $"Has Backoff reached max: {hasBackoReachedMax} with number of Attempts:{_backo.CurrentAttempt},\n Status Code: {statusCode}\n, response message: {responseStr}";`
`348`	`348`	`Fail(batch, new APIException(statusCode.ToString(), message), watch.ElapsedMilliseconds);`
`349`		`- if (_backo.HasReachedMax)`
`350`		`- {`
`351`		`- _backo.Reset();`
`352`		`- }`
`353`	`349`	`}`
`354`	`350`	`}`
`355`	`351`	`catch (System.Exception e)`