Commit 4127749
authored
* Bump Eigen submodule to 5.0.0
Updates Dependencies/eigen from a pre-3.5 dev snapshot
(87300c93c, 2023-04-17) to the released 5.0.0 tag (549bf8c75,
2025-09-28).
Why this closes #67
-------------------
Issue #67 asks that we follow Eigen's struct-having-Eigen-members
guidance to ensure correct alignment of Eigen members. The Eigen 5.0
release notes resolve this at the library level:
> Eigen now uses the c++11 alignas keyword for static alignment.
> Users targeting C++17 only and recent compilers (e.g., GCC>=7,
> clang>=5, MSVC>=19.12) will thus be able to completely forget about
> all issues related to static alignment, including
> EIGEN_MAKE_ALIGNED_OPERATOR_NEW.
NAM already requires C++20 (see CMakeLists.txt). With Eigen 5.0, the
README "Sharp edges" workarounds (EIGEN_MAX_ALIGN_BYTES=0,
EIGEN_DONT_VECTORIZE) are no longer needed. A follow-up commit can
remove that section.
Refs #67.
* Bump Eigen submodule 5.0.0 -> 5.0.1
Picks up 5.0.1 patch fixes, notably alignment fixes (#2982, #2984) and a
missing C++20 <version> header (#2986) - both directly relevant to NAM's
C++20 build and to the alignment issue this PR closes (#67).
Local matrix re-verified (macOS, AppleClang, C++20):
- default + inline GEMM: clean build, run_tests pass
- render output bit-exact vs 5.0.0 (default and inline hashes unchanged)
1 parent b352966 commit 4127749
1 file changed
Lines changed: 1 addition & 1 deletion
Submodule eigen updated from 87300c9 to bc3b398
0 commit comments