Skip to content

Conversation

@Lawliet-Chan
Copy link

Your PR title must follow conventional commits, and should start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Example commit messages:

  • feat: adds support for gnosis safe wallet
  • fix: removes a polling memory leak
  • chore: bumps redux version

Other things to note:

  • Please describe the change using verb statements (ex: Removes X from Y)
  • PRs with multiple changes should use a list of verb statements
  • Add any relevant unit / integration tests
  • Changes will be previewable via vercel. Non-obvious changes should include instructions for how to reproduce them

@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for poetic-druid-d5253e ready!

Name Link
🔨 Latest commit 675ce58
🔍 Latest deploy log https://app.netlify.com/sites/poetic-druid-d5253e/deploys/643671517f591c00082b9eb0
😎 Deploy Preview https://deploy-preview-11--poetic-druid-d5253e.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dghelm
Copy link

dghelm commented Mar 27, 2023

Can we please merge this into a different branch? Perhaps scroll-staging? Then I can setup netlify automations for that branch.

@dghelm
Copy link

dghelm commented Mar 27, 2023

To fix the TS error, try doing a search for SupportedChainId.SCROLL_ALPHA, and making sure you've also added SupportedChainId.SCROLL_STAGING,

A quick review: In src/constants/chains.ts L42 you'll want to give the network a name and also add the network around lines 82 and 112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants