public email issue

[radaniba]

The library seems to grab user's public email. Some users do not list it when they edit their profile at github which means that if you want to populate a db table with user field to be email, this will fail because this api will extract a NULL field.

Is there any fix to that ?

[radaniba]

Well this is the fix if you want to update this library.
Here is the problem, imagine you have an app running and that will synchronize a github account using email, if you use the email the way you do it here (public email) and if a user changes his public email then the syncronization may happen with another account in your app, which is a big problem !
You, then want to use the email address that was used for the github account creation rather than the public email in the profile page, which can be btw empty !

So in your authorize.php you may want to do something like this

$accesstoken = $this->github->get_access_token();
            $emails = file_get_contents("https://api.github.com/user/emails?access_token=$accesstoken");
            $emails = json_decode($emails,true);
            //print_r($emails);
            $email = $emails[0];
            $user = array(
                    'github_id' => $github_user->id,
                    'name' => $github_user->name,
                    'email' => $email,
                    'login' => $github_user->login,
                    'type' => $github_user->type,
                    'company' => $github_user->company,
                    'avatar_url' => $github_user->avatar_url,
                    'hireable' => $github_user->hireable,
                    'blog' => $github_user->blog,
                    'bio' => $github_user->bio,
                    'gravatar_id' => $github_user->gravatar_id,
                    'location' => $github_user->location,
                    'access_token' => $this->github->get_access_token()
            );

That way you are sure to extract a valid and unique email address that will let you away from confusion

Hope that helps

[whatnickcodes]

@biocodershub, Thanks for looking into this. I'm reopening this until I can get the time to look into this further in case other people face the issue. I'm glad the library worked out for you so far. Would love to learn more about your work when it's completed.

[radaniba]

+1 @ncerminara I will get back to you when I finish. Thank you for this library !