Return success from SelfUpdater.update

Change SelfUpdater.update to return a Bool indicating whether the install/relaunch succeeded (true) or failed (false). Update AccountsViewModel.installUpdate to await that result and only record the rolling release timestamp after a successful install; remove the pre-install timestamp recording. This ensures rolling timestamps are only recorded on successful updates.

Author: sameerbajaj

CodexAccounts/Services/SelfUpdater.swift

@@ -27,7 +27,7 @@ enum SelfUpdater {
     static func update(
         dmgURL: URL,
         onStateChange: @escaping @MainActor (SelfUpdateState) -> Void
-    ) async {
+    ) async -> Bool {
         do {
             // 1 — Download
             await MainActor.run { onStateChange(.downloading(progress: 0)) }
@@ -54,9 +54,11 @@ enum SelfUpdater {
 
             // 7 — Relaunch
             relaunchApp(at: runningAppURL)
+            return true
 
         } catch {
             await MainActor.run { onStateChange(.failed(error.localizedDescription)) }
+            return false
         }
     }
 

CodexAccounts/Services/UpdateChecker.swift

@@ -60,10 +60,13 @@ enum UpdateChecker {
         if let latest = releases.first(where: { $0.tagName == "latest" }),
            let publishedAt = latest.publishedAt {
             let baseline = max(buildTimestamp, lastInstalledRollingTimestamp)
-            if baseline > 0 && publishedAt > baseline + 60 {
+            let releaseVersion = version(from: latest.name)
+            if releaseVersion.map({ isNewer($0, than: currentVersion) }) == true
+                || (baseline > 0 && publishedAt > baseline + 60)
+            {
                 // Remote is at least 1 min newer — a real push happened
                 return UpdateInfo(
-                    version: "latest",
+                    version: releaseVersion ?? "latest",
                     tagName: "latest",
                     releaseURL: URL(string: latest.htmlURL) ?? releasesPage,
                     downloadURL: preferredDMGURL(in: latest),
@@ -112,6 +115,16 @@ enum UpdateChecker {
         return s
     }
 
+    private static func version(from text: String?) -> String? {
+        guard let text else { return nil }
+        let pattern = #"\b(\d+)\.(\d+)\.(\d+)\b"#
+        guard let regex = try? NSRegularExpression(pattern: pattern),
+              let match = regex.firstMatch(in: text, range: NSRange(text.startIndex..., in: text)),
+              let range = Range(match.range, in: text)
+        else { return nil }
+        return String(text[range])
+    }
+
     private static func isNewer(_ a: String, than b: String) -> Bool {
         let av = a.split(separator: ".").compactMap { Int($0) }
         let bv = b.split(separator: ".").compactMap { Int($0) }
@@ -134,6 +147,7 @@ enum UpdateChecker {
 
 private struct GitHubRelease: Decodable {
     let tagName:     String
+    let name:        String?
     let htmlURL:     String
     let draft:       Bool
     let prerelease:  Bool
@@ -143,6 +157,7 @@ private struct GitHubRelease: Decodable {
 
     enum CodingKeys: String, CodingKey {
         case tagName    = "tag_name"
+        case name
         case htmlURL    = "html_url"
         case draft, prerelease, body
         case publishedAt = "published_at"
@@ -152,6 +167,7 @@ private struct GitHubRelease: Decodable {
     init(from decoder: Decoder) throws {
         let c = try decoder.container(keyedBy: CodingKeys.self)
         tagName    = try c.decode(String.self, forKey: .tagName)
+        name       = try c.decodeIfPresent(String.self, forKey: .name)
         htmlURL    = try c.decode(String.self, forKey: .htmlURL)
         draft      = try c.decode(Bool.self,   forKey: .draft)
         prerelease = try c.decode(Bool.self,   forKey: .prerelease)

CodexAccounts/ViewModels/AccountsViewModel.swift

@@ -533,16 +533,15 @@ final class AccountsViewModel {
     func installUpdate() {
         guard let update = availableUpdate, let dmgURL = update.downloadURL else { return }
 
-        if update.isRolling, let ts = update.publishedAt {
-            UpdateChecker.recordInstalledRollingTimestamp(ts)
-        }
-
         Task {
-            await SelfUpdater.update(dmgURL: dmgURL) { [weak self] state in
+            let didInstall = await SelfUpdater.update(dmgURL: dmgURL) { [weak self] state in
                 Task { @MainActor in
                     self?.selfUpdateState = state
                 }
             }
+            if didInstall, update.isRolling, let ts = update.publishedAt {
+                UpdateChecker.recordInstalledRollingTimestamp(ts)
+            }
         }
     }