-
Notifications
You must be signed in to change notification settings - Fork 10
POC: Request through undici #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Corvince
wants to merge
21
commits into
sagemathinc:main
Choose a base branch
from
Corvince:http2-incoming
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e510089
POC: Request through undici
111d6fc
convert undici handling to alternative code path
bf7f015
Furhter refinements so all tests except those dependent on "proxyReq"…
697d838
small refactor, fix ts errors
0315956
ts: check for href before use
8c2f62c
enable h2 option for http2 to http2 test
769957b
feat: Add callback functions, group options
e8d0504
Add documentation for undici code path
94c72bb
unify error handling and reuse agents
979ea48
update documentation and test runs for both code paths
0ca2eb7
test both code paths in ci
a24e06b
wip: switch to fetch
3128888
wip: fix typescript errors
db6dc43
fix body streaming and some tests
e09a140
updated forced undici/fetch path handling
b6ef353
fix comment
2bd026b
fix path logic and duplex option
a5227b3
chore: Remove all mentions of undici vs fetch, where appropriate. Upd…
ddf7f05
chore: Maybe remove whitespace changes
7e5f891
Merge branch 'main' of https://github.com/sagemathinc/http-proxy-3 in…
ba769a6
Address code review issues
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| { | ||
| "$schema": "https://biomejs.dev/schemas/2.2.5/schema.json", | ||
| "vcs": { | ||
| "enabled": false, | ||
| "clientKind": "git", | ||
| "useIgnoreFile": false | ||
| }, | ||
| "files": { | ||
| "ignoreUnknown": false | ||
| }, | ||
| "formatter": { | ||
| "enabled": true, | ||
| "indentStyle": "space", | ||
| "lineWidth": 120 | ||
| }, | ||
| "linter": { | ||
| "enabled": true, | ||
| "rules": { | ||
| "recommended": true | ||
| } | ||
| }, | ||
| "javascript": { | ||
| "formatter": { | ||
| "quoteStyle": "double" | ||
| } | ||
| }, | ||
| "assist": { | ||
| "enabled": true, | ||
| "actions": { | ||
| "source": { | ||
| "organizeImports": "on" | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation shows
customFetchbeing used in the example, but this option is not implemented in the actual code (the stream2 function always uses the globalfetch). Either implement support for this option or remove it from the documentation to avoid confusion.