Address review feedback

Author: 2opremio

ansible/roles/controller-ccv/templates/chainlet/chainlet-deploy.yml.tmpl.j2

@@ -126,15 +126,17 @@ spec:
             value: "{{ .ChainPeers }}"
           - name: NODE_KEY
             value: "{{ .NodeKey }}"
-          {{- if .ValidatorKey }}
-          - name: VALIDATOR_KEY
-            value: "{{ .ValidatorKey }}"
-          {{- else }}
+{% if controller_remote_signer_enabled %}
           - name: REMOTE_SIGNER_ENABLED
             value: "true"
           - name: PRIV_VALIDATOR_LADDR
             value: "tcp://0.0.0.0:26658"
+{% else %}
+          {{- if .ValidatorKey }}
+          - name: VALIDATOR_KEY
+            value: "{{ .ValidatorKey }}"
           {{- end }}
+{% endif %}
           - name: OPTS
             value: "--pruning %%% pruning_strategy %%% --json-rpc.gas-cap 50000004 --api.enable=false --grpc.enable=true"
           - name: CHAINID
@@ -207,10 +209,10 @@ spec:
             - containerPort: 8545
             - containerPort: 8546
             - containerPort: 26660
-          {{- if not .ValidatorKey }}
+{% if controller_remote_signer_enabled %}
             - containerPort: 26658
               name: privval
-          {{- end }}
+{% endif %}
           resources:
             %%% controller_chainlet_resources | to_nice_yaml(indent=2) | indent(12, true) | trim %%%
           volumeMounts:

ansible/roles/controller/defaults/main.yml

@@ -26,4 +26,7 @@ controller_relayer_version: "0.4.2"
 controller_relayer_wait_time: "0"
 # Load Balancer Configuration
 controller_chainlet_external_traffic_policy: Cluster
-controller_chainlet_allocate_loadbalancer_node_ports: false
+controller_chainlet_allocate_loadbalancer_node_ports: false
+
+# Signer
+controller_remote_signer_enabled: false

ansible/roles/controller/templates/chainlet/chainlet-deploy.yml.tmpl.j2

@@ -86,15 +86,12 @@ spec:
             value: "%%% stake_owner_address %%%"
           - name: KEYPASSWD
             value: "%%% keychain_password %%%"
-          {{- if .ValidatorKey }}
-          - name: VALIDATOR_KEY
-            value: "{{ .ValidatorKey }}"
-          {{- else }}
+{% if controller_remote_signer_enabled %}
           - name: REMOTE_SIGNER_ENABLED
             value: "true"
           - name: PRIV_VALIDATOR_LADDR
             value: "tcp://0.0.0.0:26658"
-          {{- end }}
+{% endif %}
           - name: AWS_ACCESS_KEY_ID
             value: "%%% aws_access_key_id %%%"
           - name: AWS_SECRET_ACCESS_KEY
@@ -141,10 +138,10 @@ spec:
             - containerPort: 8545
             - containerPort: 8546
             - containerPort: 26660
-          {{- if not .ValidatorKey }}
+{% if controller_remote_signer_enabled %}
             - containerPort: 26658
               name: privval
-          {{- end }}
+{% endif %}
           resources:
             %%% controller_chainlet_resources | to_nice_yaml(indent=2) | indent(12, true) | trim %%%
           volumeMounts: