Mark windows-gnu* as lacking build with assertions #149507
Merged
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-CI
Member
Author
|
@bors try jobs=dist-x86_64-llvm-mingw,dist-x86_64-mingw,x86_64-mingw-1,x86_64-mingw-2 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 1, 2025
Mark windows-gnu* as lacking build with assertions try-job: dist-x86_64-llvm-mingw try-job: dist-x86_64-mingw try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
Collaborator
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @clubby789 rustbot has assigned @clubby789. Use |
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 2, 2025
Rollup of 8 pull requests Successful merges: - #145628 ([std][BTree] Fix behavior of `::append` to match documentation, `::insert`, and `::extend`) - #149241 (Fix armv4t- and armv5te- bare metal targets) - #149470 (compiletest: Prepare ignore/only conditions once in advance, without a macro) - #149507 (Mark windows-gnu* as lacking build with assertions) - #149508 (Prefer helper functions to identify MinGW targets) - #149516 (Stop adding MSYS2 to PATH) - #149525 (debuginfo/macro-stepping test: extend comments) - #149526 (Add myself (mati865) to the review rotation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 2, 2025
Rollup merge of #149507 - mati865:windows-gnu-like-no-asserts, r=clubby789 Mark windows-gnu* as lacking build with assertions Knowing that `x86_64-pc-windows-gnu` has no builds with assertions, I have just copied it as `x86_64-pc-windows-gnullvm` and called a day. Obviously it should have been `false`, sorry for that. While at it, also fix `x86_64-pc-windows-gnu`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knowing that
x86_64-pc-windows-gnuhas no builds with assertions, I have just copied it asx86_64-pc-windows-gnullvmand called a day. Obviously it should have beenfalse, sorry for that.While at it, also fix
x86_64-pc-windows-gnu.