Skip to content

Commit ed2767a

Browse files
committed
WIP
1 parent 843f8ce commit ed2767a

File tree

4 files changed

+5
-9
lines changed

4 files changed

+5
-9
lines changed

package-lock.json

Lines changed: 0 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
"browser-ui-test": "^0.22.2",
44
"es-check": "^6.2.1",
55
"eslint": "^8.57.1",
6-
"eslint-js": "github:eslint/js",
76
"typescript": "^5.8.3"
87
}
98
}

src/build_helper/src/npm.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,19 @@ pub fn install(src_root_path: &Path, out_dir: &Path, npm: &Path) -> Result<PathB
2020

2121
let mut cmd = Command::new(npm);
2222
if CiEnv::is_ci() {
23+
eprintln!("Running npm ci");
2324
// `npm ci` redownloads every time and thus is too slow for local development.
2425
cmd.arg("ci");
2526
} else {
27+
eprintln!("Running npm install");
2628
cmd.arg("install");
2729
}
2830
// disable a bunch of things we don't want.
2931
// this makes tidy output less noisy, and also significantly improves runtime
3032
// of repeated tidy invocations.
3133
cmd.args(&["--audit=false", "--save=false", "--fund=false"]);
3234
cmd.current_dir(out_dir);
35+
eprintln!("Executing {cmd:?}");
3336
let exit_status = cmd.spawn()?.wait()?;
3437
if !exit_status.success() {
3538
eprintln!("npm install did not exit successfully");

src/tools/tidy/src/extra_checks/mod.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,9 @@ fn check_impl(
324324
}
325325

326326
if js_lint || js_typecheck {
327+
eprintln!("Running npm install");
327328
rustdoc_js::npm_install(root_path, outdir, npm)?;
329+
eprintln!("Finished npm install");
328330
}
329331

330332
if js_lint {

0 commit comments

Comments
 (0)