Never true condition

[nobu]

The never-true condition

https://github.com/rubygems/rubygems/blob/83297265aa75b608c75e395b4bb06ffa78a9b52d/lib/rubygems/specification.rb#L1098

As you know, false is the only instance of FalseClass.
If spec is false the RHS will not be evaluated of course and this expression cannot be true usually.
I don't think gemspec files are using classes overriding class method.

Digging

The RHS of this expression seems originally added to catch in Gem::BuildCommand#load_gemspec at 688de7f.
This spec is the result of YAML.load (probably Syck at that time), and it seems to return false when the input contains no entities (an empty input, whitespaces or comment only).

Then 2fbc2b6 added the LHS.
I guess "Raise exception if loaded spec is nil" means the next block, as the expression became never-true at this point.
This may be to support Psych.

Conclusion

I consider this code (and Gem::EndOfYAMLException too?) useless, and can be removed.

How do you think about it?

[deivid-rodriguez]

Makes sense @nobu, thanks for digging and PR appreciated!

[deivid-rodriguez]

@nobu Are you still interested in simplifying this code?