Fix no remote check. #746
Open
Fix no remote check. #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check has likely never worked as intended. I'm not aware of any case where `len()` returns a negative nubmer. The described error seems like the intent was to check for an empty list of remotes not a somehow negative number of remotes. When updating this check, there are several test failures which i have not triaged. It's possible that now-expected behavior is incompatible with this remote check or that our test fixtures need to be updated so they don't cause this error.
|
FYI @wjwwood in case there was once a valid way for |
|
I can't think of one, likely a bug that prevented us from catching this condition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check has likely never worked as intended. I'm not aware of any case where
len()returns a negative nubmer. The described error seems like the intent was to check for an empty list of remotes not a somehow negative number of remotes.When updating this check, there are several test failures which i have not triaged. It's possible that now-expected behavior is incompatible with this remote check or that our test fixtures need to be updated so they don't cause this error.