- Allowing OFFSET without LIMIT

Author: rkrx

src/Builder/Select.php

@@ -145,7 +145,7 @@ public function __toString() {
 		$query = $this->buildGroups($query);
 		$query = $this->buildHavingConditions($query);
 		$query = $this->buildOrder($query);
-		$query = $this->buildLimit($query);
+		$query = $this->buildLimit($query, $this->getOffset());
 		$query = $this->buildOffset($query);
 		$query = $this->buildUnions($query);
 		$query = $this->buildForUpdate($query);

src/Builder/Traits/LimitBuilder.php

@@ -5,6 +5,13 @@ trait LimitBuilder {
 	/** @var int */
 	private $limit = null;
 
+	/**
+	 * @return int
+	 */
+	protected function getLimit() {
+		return $this->limit;
+	}
+
 	/**
 	 * @param int $limit
 	 * @return $this
@@ -16,11 +23,16 @@ public function limit($limit) {
 
 	/**
 	 * @param string $query
+	 * @param null $offset
 	 * @return string
 	 */
-	protected function buildLimit($query) {
-		if($this->limit !== null) {
-			$query .= "LIMIT\n\t{$this->limit}\n";
+	protected function buildLimit($query, $offset = null) {
+		$limit = $this->limit;
+		if($limit === null && $offset !== null) {
+			$limit = '18446744073709551615';
+		}
+		if($limit !== null) {
+			$query .= "LIMIT\n\t{$limit}\n";
 		}
 		return $query;
 	}

src/Builder/Traits/OffsetBuilder.php

@@ -5,6 +5,13 @@ trait OffsetBuilder {
 	/** @var int */
 	private $offset = null;
 
+	/**
+	 * @return int
+	 */
+	protected function getOffset() {
+		return $this->offset;
+	}
+
 	/**
 	 * @param int $offset
 	 * @return $this

tests/Builder/SelectTest.php

@@ -146,6 +146,15 @@ public function testOffset() {
 		$this->assertEquals("SELECT\n\ta\nFROM\n\ttest t\nLIMIT\n\t100\nOFFSET\n\t50\n", $str);
 	}
 
+	public function testOffsetWithoutLimit() {
+		$str = TestSelect::create()
+		->field('a')
+		->from('t', 'test')
+		->offset(50)
+		->asString();
+		$this->assertEquals("SELECT\n\ta\nFROM\n\ttest t\nLIMIT\n\t18446744073709551615\nOFFSET\n\t50\n", $str);
+	}
+
 	public function testForUpdate() {
 		$str = TestSelect::create()
 		->field('a')