- Minor fix

Author: rkr

src/Databases/MySQL.php

@@ -136,10 +136,6 @@ public function quoteExpression($expression, array $arguments = array()) {
 			$idx++;
 			$index = $idx;
 
-			if(substr($oldValue[0], 0, 1) == ':') {
-				$index = (int) substr($oldValue[0], 1);
-			}
-
 			if(array_key_exists($index, $arguments)) {
 				$argument = $arguments[$index];
 				$value = $this->quote($argument);
@@ -148,7 +144,7 @@ public function quoteExpression($expression, array $arguments = array()) {
 			}
 			return $value;
 		};
-		$result = preg_replace_callback('/(\\?|:\\d+)/', $func, $expression);
+		$result = preg_replace_callback('/(\\?)/', $func, $expression);
 		return (string) $result;
 	}
 

tests/Builder/InsertTest.php

@@ -147,6 +147,6 @@ public function testExprWithParams() {
 		->updateExpr('b=?', 'b')
 		->addOrUpdateExpr('c=?', 'c')
 		->asString();
-		$this->assertEquals("INSERT INTO\n\ttest\nSET\n\ta='a',\n\tb='b'\n", $sql);
+		$this->assertEquals("INSERT INTO\n\ttest\nSET\n\ta='a',\n\tc='c'\nON DUPLICATE KEY UPDATE\n\tb='b',\n\tc='c'\n", $sql);
 	}
 }

tests/Builder/SelectTest.php

@@ -63,13 +63,6 @@ public function testWhere() {
 		->where('a < ?', 1000)
 		->asString();
 		$this->assertEquals("SELECT\n\ta\nFROM\n\ttest t\nWHERE\n\t(a < '1000')\n", $str);
-
-		$str = TestSelect::create()
-		->field('a')
-		->from('t', 'test')
-		->where('a < :0', 1000)
-		->asString();
-		$this->assertEquals("SELECT\n\ta\nFROM\n\ttest t\nWHERE\n\t(a < '1000')\n", $str);
 	}
 
 	public function testHaving() {