Track job milestone timestamps directly in JobHandler (#90)

This makes it easier for hooks to work with these times,
rather than having to track those for every job themselves.

Previously you could do this with dynamic properties on the
JobHandler class, but that is deprecated in PHP 8.2.

Author: pprkut

lib/JobHandler.php

@@ -34,6 +34,21 @@ class JobHandler
 	 */
 	public $payload;
 
+	/**
+	 * @var float Timestamp of when the data was popped from redis.
+	 */
+	public $popTime;
+
+	/**
+	 * @var float Timestamp of when the job started processing.
+	 */
+	public $startTime;
+
+	/**
+	 * @var float Timestamp of when the job finished processing.
+	 */
+	public $endTime;
+
 	/**
 	 * @var object|\Resque\Job\JobInterface Instance of the class performing work for this job.
 	 */
@@ -54,6 +69,7 @@ public function __construct($queue, $payload)
 	{
 		$this->queue = $queue;
 		$this->payload = $payload;
+		$this->popTime = microtime(true);
 	}
 
 	/**
@@ -206,6 +222,8 @@ public function perform()
 		try {
 			Event::trigger('beforePerform', $this);
 
+			$this->startTime = microtime(true);
+
 			$instance = $this->getInstance();
 			if (is_callable([$instance, 'setUp'])) {
 				$instance->setUp();
@@ -217,6 +235,8 @@ public function perform()
 				$instance->tearDown();
 			}
 
+			$this->endTime = microtime(true);
+
 			Event::trigger('afterPerform', $this);
 		} catch (DoNotPerformException $e) {
 			// beforePerform/setUp have said don't perform this job. Return.
@@ -233,6 +253,8 @@ public function perform()
 	 */
 	public function fail($exception)
 	{
+		$this->endTime = microtime(true);
+
 		Event::trigger('onFailure', array(
 			'exception' => $exception,
 			'job' => $this,

test/Resque/Tests/JobHandlerTest.php

@@ -452,6 +452,57 @@ public function testJobCanBeRecreatedFromLegacyPayload()
 		$this->assertEquals('Resque\Tests\Some_Job_Class', $newJob->payload['class']);
 		$this->assertNotNull($newJob->payload['id']);
 	}
+
+	public function testJobHandlerSetsPopTime()
+	{
+		$payload = array(
+			'class' => 'Resque\Tests\Some_Job_Class',
+			'args' => null
+		);
+
+		$now = microtime(true);
+
+		$job = new JobHandler('jobs', $payload);
+		$instance = $job->getInstance();
+
+		$this->assertIsFloat($job->popTime);
+		$this->assertTrue($job->popTime >= $now);
+	}
+
+	public function testJobHandlerSetsStartAndEndTimeForSuccessfulJob()
+	{
+		$payload = array(
+			'class' => 'Resque\Tests\Some_Job_Class',
+			'args' => null
+		);
+
+		$job = new JobHandler('jobs', $payload);
+		$job->perform();
+
+		$this->assertIsFloat($job->startTime);
+		$this->assertTrue($job->startTime >= $job->popTime);
+
+		$this->assertIsFloat($job->endTime);
+		$this->assertTrue($job->endTime >= $job->startTime);
+	}
+
+	public function testJobHandlerSetsStartAndEndTimeForFailedJob()
+	{
+		$payload = array(
+			'class' => 'Failing_Job',
+			'args' => null
+		);
+		$job = new JobHandler('jobs', $payload);
+		$job->worker = $this->worker;
+
+		$this->worker->perform($job);
+
+		$this->assertIsFloat($job->startTime);
+		$this->assertTrue($job->startTime >= $job->popTime);
+
+		$this->assertIsFloat($job->endTime);
+		$this->assertTrue($job->endTime >= $job->startTime);
+	}
 }
 
 class Some_Job_Class implements JobInterface