docs(results) - refactor logic into a hook #402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gabrielseco
commented
Aug 19, 2025
| employerAmount?: string; | ||
| description?: string; | ||
| zendeskId?: string; | ||
| zendeskURL?: string; |
Collaborator
Author
There was a problem hiding this comment.
we forgot to remove this when we merged the other PR about zendesk
gabrielseco
commented
Aug 19, 2025
| } | ||
|
|
||
| .RemoteFlows__Estimation__Separator { | ||
| .RemoteFlows__Separator { |
Collaborator
Author
There was a problem hiding this comment.
I will need this in another component
eng-almeida
reviewed
Aug 20, 2025
| ); | ||
| } | ||
|
|
||
| const useEstimationResults = (estimation: CostCalculatorEmployment) => { |
Collaborator
There was a problem hiding this comment.
There's no state change is this function, right? So why is it a hook?
Collaborator
Author
There was a problem hiding this comment.
it was to separate the logic from the render function
If a partner wants to have the data normalized to do the component, we could share this hook
I follow the same pattern here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing something else and I figure out that it would be a good idea to put the logic inside a hook, in case we need to give the hook to let partners render the component but at least the logic is done.