Skip to content

Commit 154a151

Browse files
vlad-dargelvlad-dargel
authored
Merge pull request #3000 from RedisInsight/e2e/bugfix/delete-zip-for-tutorials
skipped custom tutorials test
2 parents 71551ef + 381ca2d commit 154a151

File tree

3 files changed

+44
-41
lines changed

3 files changed

+44
-41
lines changed

‎tests/e2e/.gitignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@ remote
55
.redisinsight
66
.redisinsight-v2
77
.redisinsight-app
8+
rihomedir

‎tests/e2e/test-data/upload-tutorials/TutorialsWithManifest.zip‎

-501 KB
Binary file not shown.

‎tests/e2e/tests/web/regression/insights/import-tutorials.e2e.ts‎

Lines changed: 43 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -114,47 +114,49 @@ test
114114
.notOk(`${tutorialName} tutorial is not uploaded`);
115115
});
116116
// https://redislabs.atlassian.net/browse/RI-4186, https://redislabs.atlassian.net/browse/RI-4213, https://redislabs.atlassian.net/browse/RI-4302
117-
test.after(async() => {
118-
tutorialName = 'Tutorials with manifest';
119-
const tutorials = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Explore);
120-
if(await tutorials.tutorialAccordionButton.withText(tutorialName).exists) {
121-
await tutorials.deleteTutorialByName(tutorialName);
122-
}
123-
await databaseAPIRequests.deleteStandaloneDatabaseApi(ossStandaloneConfig);
124-
})('Verify that user can upload tutorial with URL with manifest.json', async t => {
125-
const labelFromManifest = 'LabelFromManifest';
126-
const link = 'https://github.com/RedisInsight/RedisInsight/raw/main/tests/e2e/test-data/upload-tutorials/TutorialsWithManifest.zip';
127-
internalLinkName1 = 'manifest-id';
128-
tutorialName = 'Tutorials with manifest';
129-
const summary = 'Summary for JSON';
130-
131-
await workbenchPage.InsightsPanel.togglePanel(true);
132-
const tutorials = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Explore);
133-
await t.click(tutorials.tutorialOpenUploadButton);
134-
// Verify that user can upload tutorials using a URL
135-
await t.typeText(tutorials.tutorialLinkField, link);
136-
await t.click(tutorials.tutorialSubmitButton);
137-
await t.expect(tutorials.tutorialAccordionButton.withText(tutorialName).with({ timeout: 20000 }).visible)
138-
.ok(`${tutorialName} tutorial is not uploaded`);
139-
await t.click(tutorials.tutorialAccordionButton.withText(tutorialName));
140-
// Verify that User can see the same structure in the tutorial uploaded as described in the .json manifest
141-
await t.expect(tutorials.getInternalLinkWithoutManifest(internalLinkName1).visible)
142-
.ok(`${internalLinkName1} folder specified in manifest is not visible`);
143-
await t.expect(tutorials.getInternalLinkWithoutManifest(internalLinkName1).textContent)
144-
.contains(labelFromManifest, `${labelFromManifest} tutorial specified in manifest is not visible`);
145-
await t.expect(tutorials.getInternalLinkWithoutManifest(internalLinkName1).textContent)
146-
.contains(summary, `${summary} tutorial specified in manifest is not visible`);
147-
await t.click(tutorials.getInternalLinkWithoutManifest(internalLinkName1));
148-
await t.expect(tutorials.scrolledEnablementArea.visible).ok('enablement area is not visible after clicked');
149-
await t.click(tutorials.closeEnablementPage);
150-
await t.click(tutorials.tutorialLatestDeleteIcon);
151-
await t.expect(tutorials.tutorialDeleteButton.visible).ok('Delete popup is not visible');
152-
await t.click(tutorials.tutorialDeleteButton);
153-
await t.expect(tutorials.tutorialDeleteButton.exists).notOk('Delete popup is still visible');
154-
// Verify that when User delete the tutorial, then User can see this tutorial and relevant markdown files are deleted from: the Enablement area in Workbench
155-
await t.expect(tutorials.tutorialAccordionButton.withText(tutorialName).exists)
156-
.notOk(`${tutorialName} tutorial is not uploaded`);
157-
});
117+
// skipped because need to move .zip tutorial to another github repository
118+
test.skip
119+
.after(async() => {
120+
tutorialName = 'Tutorials with manifest';
121+
const tutorials = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Explore);
122+
if(await tutorials.tutorialAccordionButton.withText(tutorialName).exists) {
123+
await tutorials.deleteTutorialByName(tutorialName);
124+
}
125+
await databaseAPIRequests.deleteStandaloneDatabaseApi(ossStandaloneConfig);
126+
})('Verify that user can upload tutorial with URL with manifest.json', async t => {
127+
const labelFromManifest = 'LabelFromManifest';
128+
const link = 'https://github.com/RedisInsight/RedisInsight/raw/main/tests/e2e/test-data/upload-tutorials/TutorialsWithManifest.zip';
129+
internalLinkName1 = 'manifest-id';
130+
tutorialName = 'Tutorials with manifest';
131+
const summary = 'Summary for JSON';
132+
133+
await workbenchPage.InsightsPanel.togglePanel(true);
134+
const tutorials = await workbenchPage.InsightsPanel.setActiveTab(ExploreTabs.Explore);
135+
await t.click(tutorials.tutorialOpenUploadButton);
136+
// Verify that user can upload tutorials using a URL
137+
await t.typeText(tutorials.tutorialLinkField, link);
138+
await t.click(tutorials.tutorialSubmitButton);
139+
await t.expect(tutorials.tutorialAccordionButton.withText(tutorialName).with({ timeout: 20000 }).visible)
140+
.ok(`${tutorialName} tutorial is not uploaded`);
141+
await t.click(tutorials.tutorialAccordionButton.withText(tutorialName));
142+
// Verify that User can see the same structure in the tutorial uploaded as described in the .json manifest
143+
await t.expect(tutorials.getInternalLinkWithoutManifest(internalLinkName1).visible)
144+
.ok(`${internalLinkName1} folder specified in manifest is not visible`);
145+
await t.expect(tutorials.getInternalLinkWithoutManifest(internalLinkName1).textContent)
146+
.contains(labelFromManifest, `${labelFromManifest} tutorial specified in manifest is not visible`);
147+
await t.expect(tutorials.getInternalLinkWithoutManifest(internalLinkName1).textContent)
148+
.contains(summary, `${summary} tutorial specified in manifest is not visible`);
149+
await t.click(tutorials.getInternalLinkWithoutManifest(internalLinkName1));
150+
await t.expect(tutorials.scrolledEnablementArea.visible).ok('enablement area is not visible after clicked');
151+
await t.click(tutorials.closeEnablementPage);
152+
await t.click(tutorials.tutorialLatestDeleteIcon);
153+
await t.expect(tutorials.tutorialDeleteButton.visible).ok('Delete popup is not visible');
154+
await t.click(tutorials.tutorialDeleteButton);
155+
await t.expect(tutorials.tutorialDeleteButton.exists).notOk('Delete popup is still visible');
156+
// Verify that when User delete the tutorial, then User can see this tutorial and relevant markdown files are deleted from: the Enablement area in Workbench
157+
await t.expect(tutorials.tutorialAccordionButton.withText(tutorialName).exists)
158+
.notOk(`${tutorialName} tutorial is not uploaded`);
159+
});
158160
// https://redislabs.atlassian.net/browse/RI-4352
159161
test
160162
.before(async t => {

0 commit comments

Comments
 (0)