Merge pull request #2232 from RedisInsight/be/feature/RI-4667_Telemetry_improvements

#RI-4667 - fix sent event

Author: vlad-dargel

redisinsight/api/src/modules/database-recommendation/database-recommendation.analytics.spec.ts

@@ -8,7 +8,7 @@ import {
 import { TelemetryEvents } from 'src/constants';
 import { DatabaseRecommendationAnalytics } from './database-recommendation.analytics';
 
-const provider = 'cloud'
+const provider = 'cloud';
 
 describe('DatabaseRecommendationAnalytics', () => {
   let service: DatabaseRecommendationAnalytics;

redisinsight/api/src/modules/database-recommendation/database-recommendation.analytics.ts

@@ -22,6 +22,7 @@ export class DatabaseRecommendationAnalytics extends TelemetryBaseService {
         },
       );
     } catch (e) {
+      // ignore
     }
   }
 }

redisinsight/api/src/modules/database-recommendation/database-recommendation.service.ts

@@ -28,17 +28,15 @@ export class DatabaseRecommendationService {
   /**
    * Create recommendation entity
    * @param clientMetadata
-   * @param recommendationName
+   * @param entity
    */
-  public async create(clientMetadata: ClientMetadata, recommendationName: string): Promise<DatabaseRecommendation> {
-    const entity = plainToClass(
-      DatabaseRecommendation,
-      { databaseId: clientMetadata?.databaseId, name: recommendationName },
-    );
+  public async create(clientMetadata: ClientMetadata, entity: DatabaseRecommendation): Promise<DatabaseRecommendation> {
+    const recommendation = await this.databaseRecommendationRepository.create(entity);
+
+    const database = await this.databaseService.get(clientMetadata?.databaseId);
+
+    this.analytics.sendCreatedRecommendationEvent(recommendation, database);
 
-    const recommendation = await this.databaseRecommendationRepository.create(entity)
-    const database = await this.databaseService.get(clientMetadata?.databaseId)
-    this.analytics.sendCreatedRecommendationEvent(recommendation, database)
     return recommendation;
   }
 
@@ -80,7 +78,7 @@ export class DatabaseRecommendationService {
           { databaseId: newClientMetadata?.databaseId, ...recommendation },
         );
 
-        return await this.databaseRecommendationRepository.create(entity);
+        return await this.create(newClientMetadata, entity);
       }
     }