Fix handling of exports with namespace specifiers (#890)

Author: danez

.changeset/itchy-planets-heal.md

@@ -0,0 +1,5 @@
+---
+'react-docgen': patch
+---
+
+Do not throw error when using namespace specifiers in export statements

packages/react-docgen/src/utils/__tests__/resolveExportDeclaration-test.ts

@@ -73,4 +73,13 @@ describe('resolveExportDeclaration', () => {
       specifiers[2].get('local'),
     ]);
   });
+
+  test('resolves named exports from with namespace', () => {
+    const exp = parse.statement<ExportNamedDeclaration>(
+      'export * as foo from "";',
+    );
+    const resolved = resolveExportDeclaration(exp);
+
+    expect(resolved).toEqual([]);
+  });
 });

packages/react-docgen/src/utils/resolveExportDeclaration.ts

@@ -24,11 +24,11 @@ export default function resolveExportDeclaration(
         definitions.push(declaration);
       }
     } else if (path.has('specifiers')) {
-      path
-        .get('specifiers')
-        .forEach((specifier) =>
-          definitions.push(specifier.get('local') as NodePath),
-        );
+      path.get('specifiers').forEach((specifier) => {
+        if (specifier.isExportSpecifier()) {
+          definitions.push(specifier.get('local'));
+        }
+      });
     }
   }
 

packages/react-docgen/tests/integration/__fixtures__/namespace-export.tsx

@@ -0,0 +1,13 @@
+import * as React from 'react';
+
+interface IProps {
+  value: string;
+}
+
+export default class extends React.Component<IProps> {
+  render() {
+    return <div/>;
+  }
+}
+
+export * as namespace from "./support/other-exports.js";

packages/react-docgen/tests/integration/__snapshots__/integration-test.ts.snap

@@ -2120,6 +2120,24 @@ exports[`integration > fixtures > processes component "flow-spread-import-type.j
 ]
 `;
 
+exports[`integration > fixtures > processes component "namespace-export.tsx" without errors 1`] = `
+[
+  {
+    "description": "",
+    "methods": [],
+    "props": {
+      "value": {
+        "description": "",
+        "required": true,
+        "tsType": {
+          "name": "string",
+        },
+      },
+    },
+  },
+]
+`;
+
 exports[`integration > fixtures > processes component "test-all-imports.tsx" without errors 1`] = `
 [
   {