docs: Remove unneeded id pk from examples

Author: ntucker

.changeset/fast-jars-run.md

@@ -0,0 +1,7 @@
+---
+'@data-client/endpoint': patch
+'@data-client/rest': patch
+'@data-client/graphql': patch
+---
+
+Fix Entity types for TS 4.0 and below

docs/core/concepts/normalization.md

@@ -29,20 +29,13 @@ class Todo extends Entity {
   readonly userId: number = 0;
   readonly title: string = '';
   readonly completed: boolean = false;
-
-  pk() {
-    return `${this.id}`;
-  }
 }
 ```
 
 ```js
 import { Entity } from '@data-client/endpoint';
 
 class Todo extends Entity {
-  pk() {
-    return `${this.id}`;
-  }
 }
 ```
 

docs/core/guides/ssr.md

@@ -94,10 +94,6 @@ class User extends Entity {
   id = '';
   username = '';
 
-  pk() {
-    return this.id;
-  }
-
   // highlight-next-line
   static key = 'User';
 }

examples/coin-app/src/resources/Currency.ts

@@ -36,10 +36,6 @@ export class Currency extends Entity {
     return iconTable[this.id]?.img_url;
   }
 
-  pk(): string {
-    return this.id;
-  }
-
   static key = 'Currency';
 
   static process(

examples/coin-app/src/resources/Product.ts

@@ -11,10 +11,6 @@ export class Product extends Entity {
   trading_disabled = false;
   stats = Stats.fromJS();
 
-  pk(): string {
-    return this.id;
-  }
-
   static key = 'Product';
   static schema = {
     stats: Stats,

examples/github-app/src/resources/Base.ts

@@ -24,10 +24,6 @@ const HOST = 'https://api.github.com';
 
 export class GithubEntity extends Entity {
   readonly id: number = -1;
-
-  pk() {
-    return this.id?.toString();
-  }
 }
 
 export const GithubGqlEndpoint = new GQLEndpoint(

examples/github-app/src/resources/Label.tsx

@@ -7,10 +7,6 @@ export class Label extends GithubEntity {
   readonly description: string = '';
   readonly color: string = '000000';
   readonly default: boolean = false;
-
-  pk() {
-    return this.id?.toString();
-  }
 }
 export const LabelResource = githubResource({
   path: '/repos/:owner/:repo/labels/:name',

examples/github-app/src/resources/Push.ts

@@ -10,7 +10,7 @@ export class Push extends GithubEntity {
   commits: Commit[] = [];
 
   pk() {
-    return `${this.pushId}`;
+    return this.pushId;
   }
 }
 

examples/github-app/src/resources/Reaction.tsx

@@ -14,10 +14,6 @@ export class Reaction extends GithubEntity {
     return contentToIcon[this.content];
   }
 
-  pk() {
-    return this.id?.toString();
-  }
-
   static schema = {
     user: User,
     createdAt: Temporal.Instant.from,

examples/nextjs/resources/PlaceholderBaseResource.ts

@@ -7,12 +7,8 @@ import {
 } from '@data-client/rest';
 
 export abstract class PlaceholderEntity extends Entity {
-  id = 0;
-
   // all Resources of `jsonplaceholder` use an id for the primary key
-  pk() {
-    return `${this.id}`;
-  }
+  id = 0;
 }
 
 /** Common patterns in the https://jsonplaceholder.typicode.com API */