From ffe8db6033951593790d58d7930b1c8f02a2ec16 Mon Sep 17 00:00:00 2001 From: Dean Attali Date: Thu, 14 Jul 2016 17:38:54 -0400 Subject: [PATCH] pass along "style" param from htmlwidgets html to custom html I think the "style" param is necessary in order to have non-default width/height eg. `fooWidget(width = "50%")` without passing along the style, the width won't actually be 50%. And I'm wondering if we need to use the `...` arguments at all? Or is it always safe to ignore them? --- vignettes/develop_advanced.Rmd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vignettes/develop_advanced.Rmd b/vignettes/develop_advanced.Rmd index 7c3a9879..8976d0f3 100644 --- a/vignettes/develop_advanced.Rmd +++ b/vignettes/develop_advanced.Rmd @@ -178,7 +178,7 @@ Typically the HTML "housing" for a widget is just a `
` element, and this is ```r sparkline_html <- function(id, style, class, ...){ - tags$span(id = id, class = class) + tags$span(id = id, class = class, style = style) } ```