You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove cache_dir parameter in favor of environment variables
Following feedback on PR vllm-project#1902, this removes the cache_dir parameter
entirely from ModelArguments, DatasetArguments, and the oneshot() API.
By removing explicit cache_dir parameters and setting all calls to
cache_dir=None, the HuggingFace libraries will automatically respect
the standard environment variable hierarchy (HF_HOME, HF_HUB_CACHE)
for determining cache locations.
This approach:
- Simplifies the codebase by removing parameter propagation
- Follows standard HuggingFace patterns
- Prevents cache_dir from being accidentally ignored
- Still fully supports offline mode via environment variables
Breaking change: Users who previously used the cache_dir parameter
should now use HF_HOME or HF_HUB_CACHE environment variables instead.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Signed-off-by: Ralph Bean <[email protected]>
0 commit comments