Do not render web console for non-HTML requests

[DanielHeath]

If I get an error fetching some JSON in an XHR request, rendering web-console isn't going to help; I'm better off dropping into a debugger on the server process.

Any interest in adding merging a PR adding rails configuration setting like config.web_console.skip_request? = lambda {|request| request.xhr?}

[gsamokovarov]

Do you happen to render this JSON in a response with HTML media type? We really try to render the console only on HTML requests:

web-console/lib/web_console/middleware.rb

Lines 54 to 56 in 83b282e

	def acceptable_content_type?(headers)
	headers["content-type"].to_s.include?("html")
	end

[DanielHeath]

That makes sense - I do have some HTML endpoints retrieved via xhr.

Perhaps also checking request.xhr? where you check acceptable_content_type? is worth doing? XHR handlers probably aren't equipped to deal with the web console.

Unfortunately this doesn't also work for the new fetch standard, since it doesn't set x-requested-with.

[gsamokovarov]

XHR requests are used in Turbo and I'm a bit reluctant to cut all of them off. Using Turbolinks or its newer incarnations is common for Rails projects.

[DanielHeath]

Turbo uses fetch, not XHR: https://github.com/hotwired/turbo/blob/main/src/http/fetch_request.ts#L97 - and has done for at least 3 years.

[gsamokovarov]

Didn't realise that fetch requests don't get the XHR header. Let me think about it some more, as I'm reluctant to add yet another one-off config to Web Console.