Add string type filtering for iz/izz commands (issue #18821) #24735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vicky-dx
commented
Oct 23, 2025
vicky-dx
commented
- Added support for filtering strings by type: iza (ascii), izu (utf8), izw (wide/utf16), izW (wide32)
- Implemented colon syntax for charset names: iz:ascii, iz:utf8, iz:wide, iz:wide32, iz:base64
- Added str_type field to RCoreBinFilter struct for passing filter through call chain
- Modified _print_strings to filter based on RBinString type field
- Updated help messages to document new filtering options
- All filters work with both iz (data sections) and izz (whole binary) commands
- Supports combination with other modifiers (json, quiet, radare mode)
|
In file included from cmd.c:97: warnings are considered errors. fix the build please |
- Added support for filtering strings by type: iza (ascii), izu (utf8), izw (wide/utf16), izW (wide32) - Implemented colon syntax for charset names: iz:ascii, iz:utf8, iz:wide, iz:wide32, iz:base64 - Added str_type field to RCoreBinFilter struct for passing filter through call chain - Modified _print_strings to filter based on RBinString type field - Updated help messages to document new filtering options - All filters work with both iz (data sections) and izz (whole binary) commands - Supports combination with other modifiers (json, quiet, radare mode) Resolves radareorg#18821
- Ignore .personal_files/ directory for work-in-progress files - Ignore TESTING_*.md files - Ignore Windows Zone.Identifier files - Ignore test backup files
vicky-dx
force-pushed
the
feature-iz-string-filter-18821
branch
from
1718440 to
a786a70
Compare
trufae
reviewed
Oct 27, 2025
| bool rdump = false; | ||
| int str_type_filter = 0; | ||
| RCoreBinFilter filter = {0}; | ||
|
|
There was a problem hiding this comment.
as reported by the lint script: ibr/core/cmd_info.inc.c:1429:
libr/core/cmd_info.inc.c:1463:
libr/core/cmd_info.inc.c:1502:
libr/core/cmd_info.inc.c:1516:
|
please fix the ci tests, the pr lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.