Fix traits.create call

Author: stevekeay

python/ironic-understack/ironic_understack/tests/test_update_baremetal_port.py

@@ -24,7 +24,7 @@
 def test_with_valid_data(mocker):
     node_uuid = uuidutils.generate_uuid()
     mock_traits = mocker.Mock()
-    mock_node = mocker.Mock(traits=mock_traits)
+    mock_node = mocker.Mock(uuid=node_uuid, traits=mock_traits)
     mock_task = mocker.Mock(node=mock_node)
     mock_port = mocker.Mock(
         uuid=uuidutils.generate_uuid(),
@@ -52,5 +52,5 @@ def test_with_valid_data(mocker):
 
     mock_traits.get_trait_names.assert_called_once()
     mock_traits.destroy.assert_called_once_with("CUSTOM_NETWORK_SWITCH")
-    mock_traits.create.assert_called_once_with("CUSTOM_STORAGE_SWITCH")
+    mock_traits.create.assert_called_once_with(node_uuid, ["CUSTOM_STORAGE_SWITCH"])
     mock_node.save.assert_called_once()

python/ironic-understack/ironic_understack/update_baremetal_port.py

@@ -212,8 +212,7 @@ def _set_node_traits(task, vlan_groups: set[str]):
         except openstack.exceptions.NotFoundException:
             pass
 
-    for trait in traits_to_add:
-        task.node.traits = task.node.traits.create(trait)
+    task.node.traits = task.node.traits.create(None, task.node.uuid, list(traits_to_add))
 
     task.node.save()