Skip to content

Commit 92851ff

Browse files
committed
Add documentation comment
1 parent a82783e commit 92851ff

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

python/ironic-understack/ironic_understack/update_baremetal_port.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ def __call__(self, task, inventory, plugin_data):
4343
with an ipv4_address address and has_carrier set to True. This is our
4444
pxe boot interface. We should clear the pxe interface flag on all other
4545
baremetal ports.
46+
47+
The interface MAC gets passed to us in plugin_data["boot_interface"] if
48+
the node was inspected by booting the IPA image. Not sure what would be
49+
set by redfish here.
4650
"""
4751
LOG.debug(f"{__class__} called with {task=!r} {inventory=!r} {plugin_data=!r}")
4852

python/ironic-understack/ironic_understack/vlan_group_name_convention.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ def vlan_group_name(switch_name: str, mapping: dict[str, str]) -> str:
1616
1717
>>> vlan_group_name("a123-20-1", {"1": "network"})
1818
>>> "a123-20-network"
19+
20+
VLAN Groups are currentlty REQUIRED to span a single cabinet. A VLAN Group
21+
that spans multiple cabinets would be named like "a123-20/21-network" but we
22+
can't support this because we have no way to determine which switches are
23+
paired together.
1924
"""
2025
switch_name = switch_name.split(".")[0].lower()
2126

0 commit comments

Comments
 (0)